When an admin selects "Use the administration theme when editing or creating content" on the Appearance page (see uploaded screenshot), it is not clear that only certain roles (the admin role) will be able to view the administration theme when editing or creating content. It is obvious to most of us because we've been doing this for a while, but it isn't clear to new users/admins.
Add a description beneath "Use the administration theme when editing or creating content" to tell users/admins that they can control which users can view the administration theme on the Permissions page.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | interdiff-2651228-7-12.txt | 1005 bytes | jordanpagewhite |
| #12 | 2651228-12.patch | 814 bytes | jordanpagewhite |
| #9 | 2651228-8.patch | 847 bytes | webbykat |
| #7 | interdiff-2651228-2-7.txt | 922 bytes | jordanpagewhite |
| #7 | 2651228-7.patch | 814 bytes | jordanpagewhite |
Comments
Comment #2
jordanpagewhite commentedI added a description beneath "Use the administration theme when editing or creating content" on the admin Appearance page. See patch and screenshot.
Comment #3
jordanpagewhite commentedNeeds review
Comment #4
pguillard commentedI wonder if it would be even better to add a link on "Permissions Page".
But it is RTBC for me.
Comment #5
jordanpagewhite commented@pguillard That is an interesting suggestion. The Permissions page already has this description, "This is only used when the site is configured to use a separate administration theme on the Appearance page.", beneath this option, "View the administration theme". I feel that is a sufficient 'alert' to admins that aren't already aware of this, but maybe I am biased because I've been doing this for a while.
My hopes, with this issue, was to avoid any potential confusion for an admin who toggled the "Use the administration theme when editing or creating content" since there is no description/alert/warning to an inexperienced admin on that page. Thank you for taking the time to review the patch. I really appreciate it.
Comment #6
alexpottI can confirm the issue. I think the help text could link to the permissions page and I think the permission needed, "View the administration theme", should be quoted.
Comment #7
jordanpagewhite commentedUpdated with suggestions. Thanks everyone for reviewing. I really appreciate it.
Comment #8
webbykat commented(Originally commented without the patch, corrected below.)
Comment #9
webbykat commentedAwesome idea - this has always nagged me too. This patch did work for me. I've suggested a minor wording update to connect the two things that must be done (checking that box, *and* granting permission) so that the option below now says:
Control which roles can "View the administration theme," if the option above is checked, on the Permissions page.
jordanpagewhite, what do you think?
Comment #10
jordanpagewhite commented@webbykat It seems to me like that might be redundant because of the phrase right above: "Use the administration theme when editing or creating content".
Comment #11
pguillard commentedI would suggest to replace @ with : for placeolder keys. Somebidy can confirm ?
Otherwise, this is RTBC for me.
Comment #12
jordanpagewhite commentedpguillard, You are correct. I've attached an updated patch and interdiff. See API docs for further explanation https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Rend...
Comment #13
pguillard commentedComment #15
catchCommitted/pushed to 8.1.x, thanks!
Comment #17
cilefen commented#2681753: "Permissions page" link in Admin > Appearance is hardcoded and breaks on subdirectory setup.