Support from Acquia helps fund testing for Drupal Acquia logo

Comments

subharanjan created an issue. See original summary.

subharanjan’s picture

Status: Active » Needs review
FileSize
1016 bytes
subharanjan’s picture

Issue summary: View changes
subharanjan’s picture

Issue summary: View changes
cilefen’s picture

Title: "Permissions page" link in Admin > Appearance page breaks on subdirectory setup. » "Permissions page" link in Admin > Appearance is hardcoded and breaks on subdirectory setup.
Component: markup » node system
Issue tags: -subdirectory setup, -Permissions page
subharanjan’s picture

Assigned: subharanjan » Unassigned
cilefen’s picture

Issue summary: View changes
cilefen’s picture

Status: Needs review » Needs work

url() is deprecated. Use Url::fromRoute() instead.

cilefen’s picture

Issue tags: +Novice

A novice can handle the next step.

lluvigne’s picture

Status: Needs work » Needs review
FileSize
1 KB
1018 bytes

Hi
in this patch i change the url() function to Url::fromRoute(), but for me doesn't work. Any idea?

Thanks

Status: Needs review » Needs work

The last submitted patch, 10: permissions_page_link-2681753-10.patch, failed testing.

lluvigne’s picture

Status: Needs work » Needs review
FileSize
1.01 KB
1.02 KB

Sorry about my last patch, the url needs to be a string, not an object. Maybe this will work (manually tested, works fine).

Sorry and thanks.

cilefen’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Novice

Good. Thank you!

  • catch committed 51372ae on 8.2.x
    Issue #2681753 by lluvigne, subharanjan, cilefen: "Permissions page"...

  • catch committed b8d93bb on 8.1.x
    Issue #2681753 by lluvigne, subharanjan, cilefen: "Permissions page"...
catch’s picture

Version: 8.2.x-dev » 8.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. The patch doesn't cherry-pick to 8.0.x so marking fixed, if you re-roll for 8.0.x before the last patch release, please reopen the issue.

nesta_’s picture

Status: Fixed » Needs review
FileSize
839 bytes

Backport to 8.0.x

Truptti’s picture

Verified the patch 'permissions_page_link-2681753-17.patch' in comment #17 on drupal 8.0.x site.Steps performed are as follows:
1.Installed Drupal site with branch 8.0.x
2.Navigated to Appearance page, Permission link was not displayed
3.Applied the patch 'permissions_page_link-2681753-17.patch'
4.Navigate to Appearance page, Permission link is displayed now and navigates to correct URL
Attached snapshot for reference.
Installed drupal 8.1.x and drupal8.2.x and observed that Permission link navigates to correct URL bydefault.

Truptti’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Closed (fixed)
Related issues: +#2651228: Add description beneath 'User the administration theme for editing content...' on the admin Appearance page

We shouldn't backport this to to 8.0.x because the original patch that caused the issue was not - see #2651228: Add description beneath 'User the administration theme for editing content...' on the admin Appearance page.

In general we try not to add new translatable strings in patch releases.