Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Follow-up to #2651228: Add description beneath 'User the administration theme for editing content...' on the admin Appearance page:
"Permissions page" link in Admin > Appearance page breaks on a subdirectory setup of Drupal. The link points to the parent host and ignores the subdirectory !! Screenshot attached about the issue: http://i.imgur.com/ktsfzWE.png
Comment | File | Size | Author |
---|---|---|---|
#18 | Permission_link_on_drupal8.2.x.JPG | 129.58 KB | Truptti |
#18 | Permission_link_working_properly_on_drupal8.1.x.JPG | 128.94 KB | Truptti |
#18 | After_patch_Drupal_8.0.x.JPG | 134.61 KB | Truptti |
#18 | Patch_applied (1).JPG | 21.39 KB | Truptti |
#18 | Before_Patch_Drupal_8.0.x.JPG | 111.16 KB | Truptti |
Comments
Comment #2
subharanjan CreditAttribution: subharanjan commentedComment #3
subharanjan CreditAttribution: subharanjan commentedComment #4
subharanjan CreditAttribution: subharanjan commentedComment #5
cilefen CreditAttribution: cilefen commentedComment #6
subharanjan CreditAttribution: subharanjan commentedComment #7
cilefen CreditAttribution: cilefen commentedComment #8
cilefen CreditAttribution: cilefen commentedurl() is deprecated. Use Url::fromRoute() instead.
Comment #9
cilefen CreditAttribution: cilefen commentedA novice can handle the next step.
Comment #10
lluvigneHi
in this patch i change the url() function to Url::fromRoute(), but for me doesn't work. Any idea?
Thanks
Comment #12
lluvigneSorry about my last patch, the url needs to be a string, not an object. Maybe this will work (manually tested, works fine).
Sorry and thanks.
Comment #13
cilefen CreditAttribution: cilefen commentedGood. Thank you!
Comment #16
catchCommitted/pushed to 8.2.x and cherry-picked to 8.1.x. The patch doesn't cherry-pick to 8.0.x so marking fixed, if you re-roll for 8.0.x before the last patch release, please reopen the issue.
Comment #17
nesta_ CreditAttribution: nesta_ at La Drupalera by Emergya commentedBackport to 8.0.x
Comment #18
Truptti CreditAttribution: Truptti at Axelerant commentedVerified the patch 'permissions_page_link-2681753-17.patch' in comment #17 on drupal 8.0.x site.Steps performed are as follows:
1.Installed Drupal site with branch 8.0.x
2.Navigated to Appearance page, Permission link was not displayed
3.Applied the patch 'permissions_page_link-2681753-17.patch'
4.Navigate to Appearance page, Permission link is displayed now and navigates to correct URL
Attached snapshot for reference.
Installed drupal 8.1.x and drupal8.2.x and observed that Permission link navigates to correct URL bydefault.
Comment #19
Truptti CreditAttribution: Truptti at Axelerant commentedComment #20
alexpottWe shouldn't backport this to to 8.0.x because the original patch that caused the issue was not - see #2651228: Add description beneath 'User the administration theme for editing content...' on the admin Appearance page.
In general we try not to add new translatable strings in patch releases.