Problem/Motivation

When an admin selects "Use the administration theme when editing or creating content" on the Appearance page (see uploaded screenshot), it is not clear that only certain roles (the admin role) will be able to view the administration theme when editing or creating content. It is obvious to most of us because we've been doing this for a while, but it isn't clear to new users/admins.

Proposed resolution

Add a description beneath "Use the administration theme when editing or creating content" to tell users/admins that they can control which users can view the administration theme on the Permissions page.

CommentFileSizeAuthor
#12 interdiff-2651228-7-12.txt1005 bytesjordanpagewhite
#12 2651228-12.patch814 bytesjordanpagewhite
#9 2651228-8.patch847 byteswebbykat
#7 interdiff-2651228-2-7.txt922 bytesjordanpagewhite
#7 2651228-7.patch814 bytesjordanpagewhite
#2 2651228-2.patch731 bytesjordanpagewhite
#2 Screen Shot 2016-01-15 at 4.50.48 PM.png72 KBjordanpagewhite
Screen Shot 2016-01-15 at 4.36.53 PM.png61.92 KBjordanpagewhite
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jordanpagewhite created an issue. See original summary.

jordanpagewhite’s picture

jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commented
FileSize
Screen Shot 2016-01-15 at 4.50.48 PM.png72 KB
2651228-2.patch731 bytes

I added a description beneath "Use the administration theme when editing or creating content" on the admin Appearance page. See patch and screenshot.

jordanpagewhite’s picture

jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commented
Status: Active » Needs review

Needs review

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Status: Needs review » Reviewed & tested by the community

I wonder if it would be even better to add a link on "Permissions Page".
But it is RTBC for me.

jordanpagewhite’s picture

jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commented

@pguillard That is an interesting suggestion. The Permissions page already has this description, "This is only used when the site is configured to use a separate administration theme on the Appearance page.", beneath this option, "View the administration theme". I feel that is a sufficient 'alert' to admins that aren't already aware of this, but maybe I am biased because I've been doing this for a while.

My hopes, with this issue, was to avoid any potential confusion for an admin who toggled the "Use the administration theme when editing or creating content" since there is no description/alert/warning to an inexperienced admin on that page. Thank you for taking the time to review the patch. I really appreciate it.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work

I can confirm the issue. I think the help text could link to the permissions page and I think the permission needed, "View the administration theme", should be quoted.

jordanpagewhite’s picture

jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commented
Status: Needs work » Needs review
FileSize
2651228-7.patch814 bytes
interdiff-2651228-2-7.txt922 bytes

Updated with suggestions. Thanks everyone for reviewing. I really appreciate it.

webbykat’s picture

webbykat CreditAttribution: webbykat as a volunteer commented

(Originally commented without the patch, corrected below.)

webbykat’s picture

webbykat CreditAttribution: webbykat as a volunteer commented
FileSize
2651228-8.patch847 bytes

Awesome idea - this has always nagged me too. This patch did work for me. I've suggested a minor wording update to connect the two things that must be done (checking that box, *and* granting permission) so that the option below now says:

Control which roles can "View the administration theme," if the option above is checked, on the Permissions page.

jordanpagewhite, what do you think?

jordanpagewhite’s picture

jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commented

@webbykat It seems to me like that might be redundant because of the phrase right above: "Use the administration theme when editing or creating content".

pguillard’s picture

pguillard CreditAttribution: pguillard commented

I would suggest to replace @ with : for placeolder keys. Somebidy can confirm ?
Otherwise, this is RTBC for me.

jordanpagewhite’s picture

jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commented
FileSize
2651228-12.patch814 bytes
interdiff-2651228-7-12.txt1005 bytes

pguillard, You are correct. I've attached an updated patch and interdiff. See API docs for further explanation https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Rend...

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Status: Needs review » Reviewed & tested by the community

  • catch committed b04e99a on 8.1.x 
    Issue #2651228 by jordanpagewhite, webbykat: Add description beneath '...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.0.x-dev » 8.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Related issues: +#2681753: "Permissions page" link in Admin > Appearance is hardcoded and breaks on subdirectory setup.

#2681753: "Permissions page" link in Admin > Appearance is hardcoded and breaks on subdirectory setup.