Move MigrationInterface out of the migrate\Entity namspace now they are plugins

Given that the Migration entity no longer exists in core I think we should just move the interface out and be done.

I'm in favour of just moving the interface and being done.

If we really are just moving the interface, then this can be marked novice.

@heddn whilst I agree this issue is novice I'd like to get the fallout from the plugins patch over asap.

Looks that got them all, RTBC. We can either add a new change record or I think we could probably get away with just adding to https://www.drupal.org/node/2668742

Testing :)

Rerolled cause #2676258: Nuke builder plugins and migration storage removed some files.

Hi,

I worked on with @alexpott latest patch and amended the issue against 8.1.x and 8.2.x. Appending the patch for testing.

Removing lines for removed files and adding new ones for newly added files.

Please review.

With additional changes from https://www.drupal.org/node/2676222#comment-10939601. Aside from just renaming the interface, its uses, docblocks, and its namespaces I have to transfer the file also as one of the suggestions by @chx.

This issue depends on #2625696: Make migrations themselves plugins instead of config entities we need to get that one done first - the point of this issue is to move the interface out of the entity namespace once migrations are no longer config entities.

#2625696: Make migrations themselves plugins instead of config entities has been done - completely remade the patch.

Just a couple more to fix.

grep -r 'migrate\\Entity' .
./modules/migrate/migrate.api.php:use Drupal\migrate\Entity\MigrationInterface;
./modules/migrate/migrate.api.php: * \Drupal\migrate\Entity\Migration, with interface
./modules/migrate/tests/modules/migrate_prepare_row_test/migrate_prepare_row_test.module:use Drupal\migrate\Entity\MigrationInterface;

@benjy thanks - fixed all the code usages - going to fix the API section on Migration configuration entities in a separate patch.

After discussion moved the interface to the Plugin directory to be consistent with the other migrate plugins. No interdiff because it would be as larger or maybe even larger than the patch.

Patch looks good, RTBC.

Rerolled - All the conflicts were on deleted files due to #2676258: Nuke builder plugins and migration storage

• core/modules/migrate/src/MigrationBuilder.php
• core/modules/migrate/src/MigrationBuilderInterface.php
• core/modules/migrate/src/Plugin/MigrateBuilderInterface.php
• core/modules/migrate_drupal/src/Plugin/migrate/builder/CckBuilder.php

Just for the record:

I see no reason to do this. I already got enough flak from Xano about BC breaks. Convince him this is OK.

Tim Millwood asked me about the plugins patch in relation to bc as well in irc, because multiversion uses it. However I pointed him to https://www.drupal.org/core/d8-bc-policy and https://www.drupal.org/core/experimental which he was not aware of. multiversion is in alpha, so it's not really a problem for them to update to 8.1.x and drop support for 8.0.x.

If people want to discuss the bc policy there are issues to do that in, but this change is completely in-line with that. If it actually causes a problem for someone, we could add an empty extending interface for bc back to the entity namespace.

Committed/pushed to 8.2.x. Leaving RTBC against 8.1.x for a cherry-pick later.

Cherry-picked to 8.1.x