Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
MigrationInterface is in Entity tho they are not entities any more
Proposed resolution
Move the interface to migrate's Plugin namespace.
Note one reference to the old interface will be left - this will be fixed in #2687003: Remove references to nonexistent functionality from migrate.api.php as that whole api section needs adjusting for the plugins patch.
Remaining tasks
User interface changes
None
API changes
Move Drupal\migrate\Entity\MigrationInterface to Drupal\migrate\Plugin\MigrationInterface
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#26 | 2676222-2-26.patch | 82.96 KB | alexpott |
#21 | 2676222-2-21.patch | 86.31 KB | alexpott |
#20 | 2676222-2-20.patch | 85.03 KB | alexpott |
#20 | 17-20-interdiff.txt | 1.67 KB | alexpott |
#20 | 2676222-2-20.patch | 85.4 KB | alexpott |
Comments
Comment #2
alexpottGiven that the Migration entity no longer exists in core I think we should just move the interface out and be done.
Comment #3
alexpottComment #4
alexpottI'm in favour of just moving the interface and being done.
Comment #5
heddnIf we really are just moving the interface, then this can be marked novice.
Comment #6
alexpott@heddn whilst I agree this issue is novice I'd like to get the fallout from the plugins patch over asap.
Comment #7
benjy CreditAttribution: benjy at PreviousNext commentedLooks that got them all, RTBC. We can either add a new change record or I think we could probably get away with just adding to https://www.drupal.org/node/2668742
Comment #8
chx CreditAttribution: chx at Smartsheet commentedI see no reason to do this. I already got enough flak from Xano about BC breaks. Convince him this is OK.
Comment #9
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedTesting :)
Comment #10
alexpottRerolled cause #2676258: Nuke builder plugins and migration storage removed some files.
Comment #13
johnrosswvsu CreditAttribution: johnrosswvsu as a volunteer and at Promet Source commentedHi,
I worked on with @alexpott latest patch and amended the issue against 8.1.x and 8.2.x. Appending the patch for testing.
Removing lines for removed files and adding new ones for newly added files.
Please review.
Comment #15
johnrosswvsu CreditAttribution: johnrosswvsu as a volunteer and at Promet Source commentedWith additional changes from https://www.drupal.org/node/2676222#comment-10939601. Aside from just renaming the interface, its uses, docblocks, and its namespaces I have to transfer the file also as one of the suggestions by @chx.
Comment #16
alexpottThis issue depends on #2625696: Make migrations themselves plugins instead of config entities we need to get that one done first - the point of this issue is to move the interface out of the entity namespace once migrations are no longer config entities.
Comment #17
alexpott#2625696: Make migrations themselves plugins instead of config entities has been done - completely remade the patch.
Comment #18
alexpottComment #19
benjy CreditAttribution: benjy at PreviousNext commentedJust a couple more to fix.
Comment #20
alexpott@benjy thanks - fixed all the code usages - going to fix the API section on Migration configuration entities in a separate patch.
Comment #21
alexpottAfter discussion moved the interface to the Plugin directory to be consistent with the other migrate plugins. No interdiff because it would be as larger or maybe even larger than the patch.
Comment #23
alexpottComment #24
benjy CreditAttribution: benjy at PreviousNext commentedPatch looks good, RTBC.
Comment #26
alexpottRerolled - All the conflicts were on deleted files due to #2676258: Nuke builder plugins and migration storage
Comment #27
alexpottComment #28
xjmComment #29
catchJust for the record:
Tim Millwood asked me about the plugins patch in relation to bc as well in irc, because multiversion uses it. However I pointed him to https://www.drupal.org/core/d8-bc-policy and https://www.drupal.org/core/experimental which he was not aware of. multiversion is in alpha, so it's not really a problem for them to update to 8.1.x and drop support for 8.0.x.
If people want to discuss the bc policy there are issues to do that in, but this change is completely in-line with that. If it actually causes a problem for someone, we could add an empty extending interface for bc back to the entity namespace.
Committed/pushed to 8.2.x. Leaving RTBC against 8.1.x for a cherry-pick later.
Comment #30
catchCherry-picked to 8.1.x