Deprecate individual schema install of system module in KernelTestBase

.

Probably best time to do this would be after the last non-security patch release for 8.0.x - then apart from last minute security release which won't have advance testing with contrib anyway, we know we're not introducing any more changes into the branch then.

Can someone explain why this is tagged against 8.1 instead of 9 ?

I.e. will this not cause a module's tests to fail again when run against both 8.0.0 and 8.1.0 ?

@tstoeckler once 8.0.x support is dropped, there'll be no tests that actually need to install those system tables, so an updated module's tests will pass - because they'll only run against 8.1.x (or 8.1.x and 8.2.x by that point).

A module that hasn't been updated will have failing tests, but we explicitly let ourselves break tests between minor releases. This one was annoying though because a test that passed on both branches was tricky to write (if at all).

Ahh so, the day that 8.1.0 is released 8.0.* is unsupported? I wasn't aware of that. Thanks for the explanation.

Yep, see https://groups.drupal.org/node/508968 and https://www.drupal.org/core/release-cycle-overview

Thanks!

Support for Drupal 8.0.x has been dropped, so lets do this.

Patch in #13 still applies. Restarting test.

I think we should add an @trigger_error() and deprecate this. That way we can fix core but not break contrib tests. And then once we allow contrib tests to define whether they should skip deprecations or not they can benefit from this info too.

So something like this maybe.

Well that shows the deprecation works.

Took out the remaining fails (I think).

Yep, the test is green, so that means that you've caught them all.

Committed c16c5d0 and pushed to 8.7.x. Thanks!

Shouldn't the deprecation notices link to a change record?

+++ b/core/tests/Drupal/KernelTests/KernelTestBase.php
@@ -728,10 +732,10 @@ protected function installSchema($module, $tables) {
+          @trigger_error('Special handling of system module schemas in \Drupal\KernelTests\KernelTestBase::installSchema has been deprecated in Drupal 8.7.x, remove any calls to this method that use invalid schema names.', E_USER_DEPRECATED);

s/invalid/individual

Also, the @deprecated on the docblock marks *all cases* of this method as deprecated/striked-through in PHPStorm. Maybe only use that if the whole method is deprecated and document this in a different way?

@jibran the work invalid here is correct.

+++ b/core/modules/block_content/tests/src/Kernel/BlockContentAccessHandlerTest.php
@@ -56,7 +56,6 @@ class BlockContentAccessHandlerTest extends KernelTestBase {
-    $this->installSchema('system', ['sequence']);

It reflects the fact that this did not cause an error. sequence is an invalid name.

Added a change record for what it worth - https://www.drupal.org/project/drupal/issues/2794347

I agree with @Berdir - we should remove the @deprecation from the method since it is only a BC behaviour of the method that has been deprecated. Let's do that in a follow-up.

Opened #3003361: Fix deprecation notice for 2670454