Problem/Motivation

We added a @deprecation notice to a method when the method itself is not deprecated only a BC layer contained within it is.

Proposed resolution

Remove it and tidy up the comments and deprecation message.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#4 3003361-4.patch1.75 KBalexpott
#4 2-4-interdiff.txt1.07 KBalexpott
#2 3003361-2.patch1.75 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 3003361-2.patch1.75 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Do we need a second dot there at the end? Other than that, looks good, thanks.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2-4-interdiff.txt1.07 KB
new 3003361-4.patch1.75 KB

We do. I was thinking exception messages :(

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed ae32952 and pushed to 8.7.x. Thanks!

  • catch committed ae32952 on 8.7.x 
    Issue #3003361 by alexpott, Berdir: Fix deprecation notice for 2670454

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

idebr’s picture

idebr commented
Related issues: +#3050363: Fix the node reference in to the deprecation notice for 2670454

This patch added a reference to https://www.drupal.org/project/drupal/issues/2794347 #2794347: Convert web tests to browser tests for field_ui module

However, this issue is not particularly relevant. This makes it harder for developers trying to remove deprecation notices from their code. I have filed #3050363: Fix the node reference in to the deprecation notice for 2670454 to update the URL to the related change record at https://www.drupal.org/node/3003360