Problem/Motivation

In this issue #2664466: url_alias table is only used by a core service but it depends on system install we are removing url_alias from the views, this make fail tests in contrib modules like #2670258-3: Add an interface for continuous translators and #2666052: Aliases created with "Not applicable" language instead of "None".
So we should add a BC layer to add support for both cases.

Proposed resolution

Remaining tasks

We can remove it when 8.1.x is released.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 interdiff-add_bc_layer_in-2670360-2-5.txt1.25 KBedurenye
#5 add_bc_layer_in-2670360-5.patch1.08 KBedurenye
#2 add_bc_layer_in-2670360-2.patch972 bytesedurenye

Comments

edurenye created an issue. See original summary.

edurenye’s picture

edurenye commented
Status: Active » Needs review
StatusFileSize
new add_bc_layer_in-2670360-2.patch972 bytes

Added the BC layer.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

The problem is that it's quite annoying for modules to support both 8.0.x and 8.1.x in tests. They have to dynamically check that and add the table or not.

We can add other such tables like router, key_value and so on as needed.

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/simpletest/src/KernelTestBase.php
@@ -429,8 +429,17 @@ protected function installSchema($module, $tables) {
+    // BC layer to avoid some contrib tests to fail.
+    // @see https://www.drupal.org/node/2670360
     $tables = (array) $tables;
+    $skip_tables = [
+      'url_alias',
+    ];
     foreach ($tables as $table) {
+      if (in_array($table, $skip_tables) && $module == 'system') {
+        continue;
+      }
       $schema = drupal_get_module_schema($module, $table);
       if (empty($schema)) {

What about adding all the tables we will do lazy in the future, and then do the skipping farther below on the function, so we basically skip the exception instead?

edurenye’s picture

edurenye commented
StatusFileSize
new add_bc_layer_in-2670360-5.patch1.08 KB
new interdiff-add_bc_layer_in-2670360-2-5.txt1.25 KB

Done, also created a follow up to remove #2670454: Deprecate individual schema install of system module in KernelTestBase it and a @todo.

Thanks for changing the status there I forgot it :)

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Looks perfect for me

juampynr’s picture

juampynr commented
Issue summary: View changes

  • catch committed 4a6c6d8 on 8.1.x 
    Issue #2670360 by edurenye: Add BC layer in installSchema to support...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x, thanks!

dawehner’s picture

dawehner
Primary language German
commented

We forgot to do the same for the new kernel test: #2672670: Add BC layer in installSchema to support url_alias for the new KernelTestBase

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.