In #2273817: Split up the UI from the rest the page_manager UI was moved to page_manager_ui, and we need it for our functional tests (which are currently failing per https://www.drupal.org/pift-ci-job/166380).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

Status: Active » Needs review
FileSize
486 bytes

Here's a patch that fixes for me locally!

  • japerry committed a238405 on authored by dsnopek
    Issue #2663530 by dsnopek: Update for move of page_manager UI's to...
japerry’s picture

Status: Needs review » Fixed

Thanks, fixed!

Status: Fixed » Needs work

The last submitted patch, 2: panels-page-manager-ui-2663530-2.patch, failed testing.

dsnopek’s picture

Status: Needs work » Active

So, this issue was an attempt to fix the branch tests, but it turns out it actually broke the branch tests. :-/ I got confused because the reason the tests were failing for me locally was missing page_manager_ui. At this point, I'm not sure why they were actually failing!

But since this issue was essentially reverted, we could reuse it for adding the page_manager_ui stuff back?

dsnopek’s picture

Issue tags: +Panels 3.0-beta4

The patch in #2 still applies to 8.x-3.x! We should test this right after the next page_manager release, and commit just before the next panels release.

The patch will need to get updated after #2662974: Move Panels-specific code out of Page Manager is committed, which we should definitely get in before the next page_manager release, because that'll allow page_manager to include #2662922: Remove PageManagerPanelsStorage and related code (in Panels now) in that release.

dsnopek’s picture

Updated this patch now that #2662974: Move Panels-specific code out of Page Manager is committed!

dsnopek’s picture

Status: Active » Needs review

Now that page_manager-1.0-alpha23 is out:

https://www.drupal.org/node/2669986

Let's run this through the tests!

  • japerry committed a463015 on 8.x-3.x authored by dsnopek
    Issue #2663530 by dsnopek: Update for move of page_manager UI's to...
japerry’s picture

Status: Needs review » Fixed

tests look.. tested! committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.