Closed (fixed)
Project:
Panels
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Feb 2016 at 16:09 UTC
Updated:
1 Mar 2016 at 20:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dsnopekHere's a patch that fixes for me locally!
Comment #4
japerryThanks, fixed!
Comment #6
dsnopekSo, this issue was an attempt to fix the branch tests, but it turns out it actually broke the branch tests. :-/ I got confused because the reason the tests were failing for me locally was missing page_manager_ui. At this point, I'm not sure why they were actually failing!
But since this issue was essentially reverted, we could reuse it for adding the page_manager_ui stuff back?
Comment #7
dsnopekThe patch in #2 still applies to 8.x-3.x! We should test this right after the next page_manager release, and commit just before the next panels release.
The patch will need to get updated after #2662974: Move Panels-specific code out of Page Manager is committed, which we should definitely get in before the next page_manager release, because that'll allow page_manager to include #2662922: Remove PageManagerPanelsStorage and related code (in Panels now) in that release.
Comment #8
dsnopekUpdated this patch now that #2662974: Move Panels-specific code out of Page Manager is committed!
Comment #9
dsnopekNow that page_manager-1.0-alpha23 is out:
https://www.drupal.org/node/2669986
Let's run this through the tests!
Comment #11
japerrytests look.. tested! committed.