Needs work
Project:
Zircon
Version:
8.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
26 Jan 2016 at 08:50 UTC
Updated:
21 May 2021 at 12:31 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
zuhair_akThe issue was a typo in zircon.libraries.yml. Please find attached patch.
Comment #3
coreykck commentedI agree, same issue for me, same fix
Comment #4
zuhair_akComment #5
mpp commentedRTBC
Comment #6
hpatt50 commentedHello,
I am a newbie with Drupal-8 and need help on how to manually apply the diff -- git monokai_css-2656702-2.patch.
More specifically, I need help with the of code;
+ - core/jquery.once
How am I suppose to add (+) the line of code then (-) take it away?
Also am I to insert the {\ No newline at end of file} as a separate line of code in the patch?
{The following is the diff -- git monokai_css-2656702-2.patch.}
Henry
diff --git a/zircon.libraries.yml b/zircon.libraries.yml
index bd6a231..3358a49 100644
--- a/zircon.libraries.yml
+++ b/zircon.libraries.yml
@@ -8,7 +8,7 @@ global-styling:
includes/fontawesome/css/font-awesome.min.css: {}
includes/slick/slick/slick.css: {}
includes/slick/css/style.css: {}
- includes/monokai/monokai.min/css: {}
+ includes/monokai/monokai.min.css: {}
includes/flexslider/flexslider.css: {}
css/html.css: {}
css/page.css: {}
@@ -38,4 +38,5 @@ global-styling:
- core/drupal.ajax
- core/drupal
- core/drupalSettings
- - core/jquery.once
\ No newline at end of file
+ - core/jquery.once
+
Comment #7
zuhair_akIgnore the last removal and addition of jquery dependancy. The correct path to monokai.css is the patch.
Comment #8
JoshOrndorff commentedPatch is indeed correct.
Comment #9
kybermanTested with default branch, please commit this patch.
Comment #10
h2cm commentedI've just downloaded Zircon theme (as a check) and if I'm reading the above correct should the line in zircon.libraries.yml still be
includes/monokai/monokai.min/css: {}
or should it read:
includes/monokai/monokai.min.css: {}
?
It is still - " includes/monokai/monokai.min/css: {} "
New to this...
Comment #11
zuhair_akIt should be
includes/monokai/monokai.min.css: {}as mentioned in the patch.Comment #12
gauravvvv commentedThe patch doesn't apply anymore. Moving to NW.