When using the proposed logging functionality (#2653394: Integration with Maillog) it would be useful if the module could also be set to not actually deliver the emails. This would be similar to the option in the Maillog module.

CommentFileSizeAuthor
#17 smtp-n2653398-17.patch3.2 KBdamienmckenna
#15 smtp-n2653398-15.patch3.19 KBdamienmckenna
#12 Screen shot 2016-01-30 at 10.38.39 PM.png33.25 KBAnonymous (not verified)
#10 Screen Shot 2016-01-30 at 2.06.56 PM.png24.73 KBgadaniels72
#3 smtp-n2653398-3.patch3.17 KBdamienmckenna
#2 smtp-n2653398-2.patch3.17 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
Related issues: +#2653394: Integration with Maillog
StatusFileSize
new smtp-n2653398-2.patch3.17 KB

This adds a new "smtp_deliver" variable which will allow the email to be generated and queued as normal, but stops just before the message is actually delivered.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new smtp-n2653398-3.patch3.17 KB

This fixes a tiny typo in the field description.

The last submitted patch, 2: smtp-n2653398-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: smtp-n2653398-3.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: smtp-n2653398-3.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

The tests pass, so marking this "needs review".

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2651788: Plan for SMTP 7.x-1.4 release

This should be safe to include in the next release, and will help with testing too.

gadaniels72’s picture

gadaniels72 commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2016-01-30 at 2.06.56 PM.png24.73 KB

Patch #3 worked for me. To test, I went to the SMTP configuration and set "turn on delivery of emails" to off. I then created a new account and marked the notify user checkbox. The report log showed a message that email delivery was disabled. No email was received. Turned mail delivery back on, ran cron, and then repeated creating a new account. Received only the one message sent after I turned email delivery back on, as I would expect.

gadaniels72’s picture

gadaniels72 commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new Screen shot 2016-01-30 at 10.38.39 PM.png33.25 KB

Works great for me. Terminal pic included.

Status: Needs review » Needs work

The last submitted patch, 3: smtp-n2653398-3.patch, failed testing.

wundo’s picture

wundo commented
Status: Needs work » Postponed (maintainer needs more info)

Damien, is this not handled by our Maillog integration? Do we need to "duplicate" this feature?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new smtp-n2653398-15.patch3.19 KB

With the Maillog integration it is still SMTP that sends the message, Maillog doesn't get involved.

Rerolled.

wundo’s picture

wundo commented
Status: Needs review » Needs work

Your patch is rolling back changes from #2698029: No ALL watchdog logging for non-queued

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new smtp-n2653398-17.patch3.2 KB

Sorry about this. This should cover it?

  • wundo committed c1bc037 on 7.x-1.x authored by DamienMcKenna 
    Issue #2653398 by DamienMcKenna: Add option to not actually deliver...
wundo’s picture

wundo commented

  • wundo committed e2af04e on 7.x-2.x authored by DamienMcKenna 
    Issue #2653398 by DamienMcKenna, gadaniels72, alex_drupal_dev, wundo:...
wundo’s picture

wundo commented
Status: Needs review » Fixed

  • wundo committed 2b2db7a on 7.x-1.x 
    Issue #2653398 by wundo: Using the TRUE/FALSE instead of 0/1 on form...

  • wundo committed dc5bf3e on 7.x-2.x 
    Issue #2653398 by wundo: Using the TRUE/FALSE instead of 0/1 on form...

Status: Fixed » Needs work

The last submitted patch, 17: smtp-n2653398-17.patch, failed testing.

wundo’s picture

wundo commented
Status: Needs work » Fixed

This was committed to both branches (7.x-1.x and 7.x-2.x)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.