From a maintenance perspective, it would be useful if there was a way of storing all of the emails being sent by the module, so that they could be monitored and problems could be debugged. Rather than writing custom code for this, just leverage the functionality in the Maillog module.

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

Issue summary: View changes
damienmckenna’s picture

Title: Add option to store copies of all emails in the database » Integration with Maillog
Issue summary: View changes

Lets just use Maillog, it'll be easier.

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new4.58 KB

This adds optional integration with the maillog module.

Status: Needs review » Needs work

The last submitted patch, 4: smtp-n2653394-4.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
damienmckenna’s picture

StatusFileSize
new5.7 KB

This version works much better.

Status: Needs review » Needs work

The last submitted patch, 7: smtp-n2653394-7.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
damienmckenna’s picture

Related issues: +#2245761: E-mail subjects longer than 255 characters lead to a fatal error
StatusFileSize
new5.72 KB

This version trims the subject to 255 chars, the same as #2245761: E-mail subjects longer than 255 characters lead to a fatal error.

Status: Needs review » Needs work

The last submitted patch, 10: smtp-n2653394-10.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
damienmckenna’s picture

StatusFileSize
new5.76 KB

The last patch didn't create the $record->body field correctly.

Status: Needs review » Needs work

The last submitted patch, 13: smtp-n2653394-13.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 13: smtp-n2653394-13.patch, failed testing.

The last submitted patch, 13: smtp-n2653394-13.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 13: smtp-n2653394-13.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new5.44 KB

Rerolled.

damienmckenna’s picture

StatusFileSize
new9.63 KB

This adds tests to confirm that the email process stores the message in maillog. FYI #2653398: Add option to not actually deliver emails might be useful too, to avoid sending emails ;-)

damienmckenna’s picture

jordanpagewhite’s picture

Status: Needs review » Reviewed & tested by the community

I can confirm that this is working, both the devel functionality and the maillog database log. I am having an issue getting the MailLog module to properly set its menu items. I have posted the issue, on a pre-existing issue, in the MailLog issue queue here: https://www.drupal.org/node/2184669#comment-10805166

wundo’s picture

  • wundo committed b44a9a8 on 7.x-1.x authored by DamienMcKenna
    Issue #2653394 by DamienMcKenna, jordanpagewhite: Integration with...
wundo’s picture

Status: Reviewed & tested by the community » Fixed
damienmckenna’s picture

Status: Fixed » Needs review
StatusFileSize
new811 bytes

@wundo: Thanks, but you missed two files ;-)

wundo’s picture

Sorry, the files were on my local, just fixed it.

  • wundo committed f95797a on 7.x-1.x
    Issue #2653394: Adding missing files
    
wundo’s picture

Status: Needs review » Fixed

Status: Fixed » Needs work

The last submitted patch, 27: smtp-n2653394-27.patch, failed testing.

wundo’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.