claroAutocompleteTest passes, but log shows a 404

The issue with this commit was #2056627: Form API autocomplete is broken for routes.

Poking around, it looks as though no tests ever try those routes:

drupal8x (8.1.x *%=)$ ack 'form-test/autocomplete-1' core/
core/modules/system/src/Tests/Form/ElementTest.php
151:    $result = $this->xpath('//input[@id="edit-autocomplete-1" and contains(@data-autocomplete-path, "form-test/autocomplete-1")]');
163:    $result = $this->xpath('//input[@id="edit-autocomplete-1" and contains(@data-autocomplete-path, "form-test/autocomplete-1")]');

core/modules/system/tests/modules/form_test/form_test.routing.yml
58:  path: '/form-test/autocomplete-1'
drupal8x (8.1.x *%=)$ ack 'form-test/autocomplete-2' core/
core/modules/system/src/Tests/Form/ElementTest.php
153:    $result = $this->xpath('//input[@id="edit-autocomplete-2" and contains(@data-autocomplete-path, "form-test/autocomplete-2/value")]');
165:    $result = $this->xpath('//input[@id="edit-autocomplete-2" and contains(@data-autocomplete-path, "form-test/autocomplete-2/value")]');

core/modules/system/tests/modules/form_test/form_test.routing.yml
65:  path: '/form-test/autocomplete-2/{param}'

drupal8x (8.1.x *%=)$ ack form_test.autocomplete_1 core/
core/modules/system/tests/modules/form_test/form_test.routing.yml
57:form_test.autocomplete_1:

core/modules/system/tests/modules/form_test/src/FormTestAutocompleteForm.php
32:      '#autocomplete_route_name' => 'form_test.autocomplete_1',
drupal8x (8.1.x *%=)$ ack form_test.autocomplete_2 core/
core/modules/system/tests/modules/form_test/form_test.routing.yml
64:form_test.autocomplete_2:

core/modules/system/tests/modules/form_test/src/FormTestAutocompleteForm.php
37:      '#autocomplete_route_name' => 'form_test.autocomplete_2',

Well if we bother patching unused test code (see #3), here it is...

Patch applies clean on 8.2.x-dev.

Well the routes are used:

  /**
   * {@inheritdoc}
   */
  public function buildForm(array $form, FormStateInterface $form_state) {
    $form['autocomplete_1'] = array(
      '#type' => 'textfield',
      '#title' => 'Autocomplete 1',
      '#autocomplete_route_name' => 'form_test.autocomplete_1',
    );
    $form['autocomplete_2'] = array(
      '#type' => 'textfield',
      '#title' => 'Autocomplete 2',
      '#autocomplete_route_name' => 'form_test.autocomplete_2',
      '#autocomplete_route_parameters' => array('param' => 'value'),
    );

    return $form;
  }

So they should be working - in fact maybe the test should be changed to a FunctionalJavascriptTest so we can test the auto complete calling beyond just the existence of the links and autocomplete.js being loaded.

I think we should do that here instead so the trivial fix is actually tested.

Tests were asked for n 2016, adding tag.

Closed #3412895: claroAutocompleteTest passes, but log shows a 404 as a duplicate and going to repurpose this issue to preserve the original credits.

So they should be working - in fact maybe the test should be changed to a FunctionalJavascriptTest so we can test the auto complete calling beyond just the existence of the links and autocomplete.js being loaded.

I think we should do that here instead so the trivial fix is actually tested.

@alexpott in #7

I disagree.

I would _love_ to convert every Nightwatch test to a FunctionalJavascriptTest, and drop Nightwatch altogether, but that's not very feasible.

Basically, we're a bit spoiled by FunctionalJavascriptTests, which not only test the (JS)-Frontend, but also look at backend errors.
Nightwatch doesn't. If the webserver spews errors in the range from 500 to 911, is on fire and with its last dying breath serves a page that meets the assertations, it's perfectly happy.

That's why claroAutocompleteTest doesn't care about the invalid routes, it only asserts certain specific layout features of a autocomplete which is in progress. The result of the autocomplete is irrelevant and as proven, not even necessary.
The test is not about the inner workings of autocomplete, nor dependent on it even working.

Like it or not, somebody somewhere decided to use a Nightwatch test for this, and I think we should stick with that.

Having said that: We should fix the routing, make the autocomplete work and test this in the Nightwatch test itself.
The latter part didn't exist in the test until now and is added.

I hope this explanation makes any kind of sense?

Confirmed the issue by going by going to the last ticket merged

https://git.drupalcode.org/issue/drupal-3409587/-/jobs/505831/artifacts/...(Coordinated-Universal-Time)_console.json

Checked this MR https://git.drupalcode.org/issue/drupal-2651798/-/jobs/587545/artifacts/...(Coordinated-Universal-Time)_console.json

And no issue.

Committed and pushed a4d53f09f6 to 11.x and e265a01324 to 10.2.x. Thanks!

Backported to 10.2.x since this only involved tests.