When copying the minified version ('jquery.cycle.all.min.js') of the jquery.cycle library to the directory /libraries/jquery.cycle/ it is not detected by the module. A workaround would be to rename 'jquery.cycle.all.min.js' to 'jquery.cycle.all.js' which is detected properly.
Was the minified version detected properly in 'Views Slideshow 7.x' or is it always expected that the minified version is renamed?
Thanks for any insights or correction.

CommentFileSizeAuthor
#2 jquery_cycle_all_min_js-2647856-2.patch1.61 KBNickDickinsonWilde
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

meichr created an issue. See original summary.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde commented
Status: Active » Needs review
FileSize
jquery_cycle_all_min_js-2647856-2.patch1.61 KB

It is cleaner to require the non-minified version and then use Core (or AdvAgg's) combine/minify functionality. Simplifies/saves code and means that if you disable minification you have the full code available for debugging. However the help text is... less than helpful. Patch attached to clarify the help text.

vbouchet’s picture

vbouchet
Location Toulouse
CreditAttribution: vbouchet at Acquia commented
Status: Needs review » Fixed

I agree with NickWilde.

I used his patch to clarify the help text and makes it really helping developers ;-)

Thanks

  • vbouchet committed bb4657d on 8.x-4.x authored by NickWilde 
    Issue #2647856 by NickWilde: jquery.cycle.all.min.js is not detected

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.