Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In the Index class (src/Entity/Index), we have the $properties property, it is however, never used to actually store something. It's only get's unset in the __sleep method.
We should remove the property and change the _sleep method.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Removed-unused-class-property-2642284-3.patch | 1.49 KB | shabirahmad |
Comments
Comment #2
shabirahmad CreditAttribution: shabirahmad as a volunteer commentedComment #3
anchal29 CreditAttribution: anchal29 as a volunteer commentedHere's a patch for it.
Comment #6
shabirahmad CreditAttribution: shabirahmad as a volunteer commentedPatch uploaded. Verified that the protected $properties is not used anywhere.
Comment #7
shabirahmad CreditAttribution: shabirahmad as a volunteer commentedComment #8
chx CreditAttribution: chx commentedLooks good!
Comment #9
borisson_Looks great, rtbc++.
Comment #11
drunken monkeyExcellent, thanks a lot!
Committed.
(Gave anchal29 a side credit, too, since his patch is almost the same, just slightly out of date (apparently) and posted while the issue was already assigned to someone else.)