Replace the entity manager with the entity type manager and remove unused imports in code base.
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | 2639706_17.patch | 38.34 KB | slashrsm |
| #13 | 2639706_13.patch | 38.67 KB | slashrsm |
| #10 | replace_the_entity-2639706-10.patch | 35.87 KB | borisson_ |
Comments
Comment #2
heykarthikwithureplaced the entity manager with the entity type manager and remove unused imports in code base.
Comment #3
slashrsm commentedThere are some more places where we inject entity.manager via create() method. We should probably convert that too.
Comment #4
heykarthikwithuchecked in the whole code and replaced.
Comment #5
slashrsm commentedThis is not the right approach. Instead of using static way we should inject entity type manager instead of entity manager and use that.
Comment #6
heykarthikwithu> Instead of using static way we should inject entity type manager instead of entity manager and use that.
currenlty this patch has entity type manager.
\Drupal::entityTypeManager()->getStorage('image_style')->loadMultiple()correct me i am wrong :).
Comment #7
slashrsm commentedThis was using injected entity manager and is not any more. There are few changes like this in the patch.
Comment #8
marvin_b8 commentedComment #9
killua99 commentedI don't see any major issue with this patch.
For me could be a RTBC but I've no idea if I could change the status (in core you can't).
Also It apply well too so it could be merged as it.
Comment #10
borisson_#8 looks great, however a couple of instances were still remaining.
Comment #11
slashrsm commentedLooks OK. Would be great to prepare patch that would update entity browser widgets that DropzoneJS ships. This way we can commit everything in one step and prevent fatals from appearing for people.
Comment #12
slashrsm commentedNeeds reroll.
Comment #13
slashrsm commentedReroll.
Comment #14
slashrsm commentedCreated a follow-up: #2763529: Update to support recent WidgetBase.php changes
Comment #17
slashrsm commentedComment #18
slashrsm commentedCommitted. Thanks!
Comment #20
samuel.mortensonCan we do a hotfix? Looks like these instances of Entity Manager were missed, breaking both widgets:
Comment #22
slashrsm commentedFixed view. Upload seems to be ok in HEAD. Rebase problem?