Closed (fixed)
Project:
Apache Solr Autocomplete
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Nov 2015 at 09:54 UTC
Updated:
4 Mar 2016 at 10:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
ursramesh commentedI enabled apachesolr_autocomplete 7.x-1.5.. it is blocking the remaining jquery. No jquery is working after enabling this module. The firebug console shows the following error "TypeError: jQuery(...).autocomplete(...).addClass(...).data(...) is undefined----.data('autocomplete')._renderItem = Drupal.apachesolr_autocomplete.renderItem". I can't use this module. I can't use this module.
Comment #3
nico.knaepen commentedComment #4
nico.knaepen commentedIssue is solved in latest dev release.
Comment #5
jacov commentedconfirmed, i ran into this and hack / patched it with the following code:
i will download the dev version. thanks
Comment #6
jacov commentedconfirmed,
i ran into the same issue and have verified that running version 1.5 does indeed have a js error in the console.
i applied the above patch from comment #3, and confirmed the js error was gone, but the autocomplete still rendered the html...see next screenshot...
so i took a different approach to the patch, and confirmed that this patch fixes both the js console error as well as the html escaping / rendering autocomplete issue.
attached my patch (also relative to the module root)
Comment #7
nico.knaepen commentedComment #8
janusman commentedSo, actually...
I applied the patch to a *stock* Drupal 7.41 install (where we are using Jquery UI 1.8.7, along with the core Bartik theme), and the current apachesolr_autocomplete-7.x-1.x (without patch) works fine, where if I add the patch I get the behavior you report as the problem and your patch supposedly fixes.
Doing some research I found this post:
http://stackoverflow.com/questions/9513251/cannot-set-property-renderite...
.. and then goes to point out something like your patch.
So, it looks like the issue you are fixing is due to you using a newer jQuery UI version--can you all confirm what version(s) you are using?
Our patch then must include conditionals to use the right syntax depending on the current jQuery UI version. Marking as needs work.
Comment #9
janusman commentedjQuery.ui.version contains the UI version, so let's use that.
Comment #10
fizk commentedComment #11
fizk commentedWe're using jQuery UI v1.10.2.
Comment #12
neraprojects commentedHi,
I have the same problem.
I have created in views a list of rendered items.
In preview, it works, but otherwise, it doesn't with the latest version of autocomplete.
Comment #13
cilefen commentedThis is why I have a test site - the same thing happened to one of my sites.
I removed unnecessary tags on the issue.
Comment #14
rooby commentedI'm also seeing this problem.
I'm on jQuery 1.8.3 and jQuery UI 1.10.2 via the jQuery update module.
I can confirm that #6 fixes the issue for this version.
Comment #15
janusman commentedSo I'm thinking we need a very simple patch doing something like this..
... pseudocode follows...
Comment #16
Mayday commentedI can confirm this is still happening on my production site. I applied the latest version (1.5) and now every jquery call is being intercepted and the warning is put into the javascript console. I am using the jquery update module and it is set to version 1.7.
Uncaught TypeError: Cannot set property '_renderItem' of undefinedFull traceback:
Comment #17
Mayday commentedComment #18
perennial.sky commentedHere is the patch, may this can solve the issue
Comment #19
perennial.sky commentedComment #20
wwwprola commented#18 Worked for me, thank you! I'm using v1.8 in jQuery Update.
Comment #21
cilefen commentedComment #22
swhitters commented#18 worked for me, too.
Comment #23
renrhafI confirm the issue, and #18 does fix the JS error that blocked the rest of the scripts. Thank you akashjain132 !
Comment #24
renrhafComment #25
renrhafFinally, the #8 patch seems to cause some errors in some situations
Comment #26
perennial.sky commentedThanks Renrhaf for reviewing the patch, Can u describe some situation when it fails.
Comment #27
renrhafIt seems in fact linked to the jQuery ui version.
I am using jQuery update on my project and it keeps failing with your patch after all.
I think we should considerer using the jQuery.version.ui as adviced in https://www.drupal.org/node/2625630#comment-10642432 to do something.
But we need feedbacks from users not having jQuery update to make sure we do not break anything.
Comment #28
perennial.sky commentedHere is the new patch, Hope this will solve the issue
Comment #29
damienmckennaThe patch in #28 works when using jQuery 1.5 via jQuery_Update 7.x-2.7.
Comment #30
fractile81 commentedConfirming that #28 works using jQuery 1.11 via jQuery Update 7.x-3.0-alpha3.
Comment #31
michaellenahan commentedConfirming that #28 works using jQuery 1.7 via jquery_update 7.x-2.7
Comment #32
neraprojects commentedConfirming that #28 works using jQuery Update 1.4
Comment #33
fizk commentedSetting patch #28 to RTBC from comments #29 - #32.
Comment #35
janusman commentedCommitted! Thanks all!
Comment #36
janusman commentedComment #37
l-laziz commentedDoes it relate to the Views AJAX exposed filter in block somehow?
Comment #38
damienmckenna@Akumaru: Just download the latest -dev snapshot, the patch should be included already.