Needs review
Project:
Contact Info
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
28 Nov 2015 at 13:28 UTC
Updated:
14 Jan 2020 at 16:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dboulet commentedHi! No work has been done to port the module to D8 so far, so patches are welcome. That can at least get us started on a new 8.x-dev branch. I’d only ask that you try as much as possible to maintain parity with the D7 version to make backporting easier.
Comment #3
rang501 commentedI have finished porting the module. The patch is attached (this can be applied to dev version).
This can be reviewed and tested now.
Comment #4
rang501 commentedComment #5
hongpong commentedI ran into trouble with the .install file as I am not familiar with the schema update process for d8. Was able to fix some minor code style notices. I removed all the leading spacing in the twig file to make its final indentations more readable, and put comments at beginning and end of the twig markup to help with development. Added a deprecation notice todo comment. Missing invisimail function for d8 noted in code, more info added to readme.
Everything else seems really good, I think it can probably be committed on a new branch. It might be good to refactor some of this code later by relying on other libraries, however it does work and isn't too complicated.
Comment #6
hongpong commented@dboulet @rang501 I was just made the co-maintainer at dormant project microformats project and if we can't do it on this module I will try to build it using the existing PHP indieweb libraries in composer. Brief plan laid out here #2718207: Request to co-maintain for great Drupal 8 indieweb foundation.
Comment #7
hongpong commentedI have it almost ported over but the block is not working yet. code is here for now. https://github.com/HongPong/microformats/tree/hcard_sitewide
Comment #8
andyd328Hi, it would be great to have a dev release for this project, even without the microformats being finished it's still very useful.
Comment #9
karthikeyan-manivasagam commentedHi,
I have ported this module to drupal 8
https://www.drupal.org/node/2893450
https://github.com/karthikeyan-manivasagam/contactinfo/
https://www.drupal.org/files/issues/ContactInfo-drupal-8-demo-video.mp4
Please release the 8.x-0.x dev version
Comment #10
hongpong commented@karthikeyan-manivasagam I will look at rolling this into microformats module if that's all right with you.
Comment #11
karthikeyan-manivasagam commented@hongpong ya sure, but this one also would be a 'D8 port' of contactinfo module, May be it will be useful for a simple drupal websites.
Comment #12
hongpong commented@karthikeyan-manivasagam I took a quick first attempt at merging your code into microformats here. #2720199: Sitewide hcards for D8, object factory?
Comment #13
hongpong commentedUpdate, thanks to mlncn this has been updated. tagging alpha release : https://www.drupal.org/project/microformats