Untangle the integration test from search api

Updated IS.

@marthinal, I took a look at the patch, it looks great but next time please use git diff -M, this reduces the patch size in half because git can actually say that files are moved instead of deleted/added.

Anyway, I took a good look at the patch and related code. I think we should fix the issues mentioned in #4 and leave the tests as-is.
The original thought of this issue was enabling testing on d.o, but because we already have that, the reasons for this aren't as strong.
We can add a tests that tests things like the integration test for core search without having to go trough such an extensive rewrite of all the tests.

I'm really sorry that you made all this effort before I thought of this.

Added a related issue.

To keep it a little bit easier, we should probably just add an extra integration test for core search, this is an initial patch for that.

Overall this is looking great, I did find some smaller issues with the code though.

1. +++ b/core_search_facets/src/Tests/IntegrationTest.php
   @@ -0,0 +1,407 @@
   +use Drupal\core_search_facets\Tests\WebTestBase as CoreSearchFacetsWebTestBase;
   

   Nice, this makes a good distinction between the base classes, marthinal++

2. +++ b/core_search_facets/src/Tests/IntegrationTest.php
   @@ -0,0 +1,407 @@
   +/**
   + * Tests the overall functionality of the Facets admin UI.
   + *
   + * @group core_search_facets
   + */
   

   I think this comment can be updated. Tests the admin UI with the core search facet source.

3. +++ b/core_search_facets/src/Tests/IntegrationTest.php
   @@ -0,0 +1,407 @@
   +   * @param $facet_name
   +   *   The name of the facet.
   

   This should be @param string $facet_name for coding standards.

4. +++ b/core_search_facets/src/Tests/IntegrationTest.php
   @@ -0,0 +1,407 @@
   +  public function setShowAmountOfResults($facet_name, $show = TRUE) {
   

   This method can be protected. We don't need it to be public.

5. +++ b/core_search_facets/src/Tests/IntegrationTest.php
   @@ -0,0 +1,407 @@
   +  /**
   +   * Helper function: asserts that a facet block does not appear.
   +   */
   ...
   +  /**
   +   * Helper function: asserts that a facet block appears.
   +   */
   

   We can probably remove the "Helper function:" here, other methods don't have that indication.

6. +++ b/core_search_facets/src/Tests/IntegrationTest.php
   @@ -0,0 +1,407 @@
   +
   

   unneeded blank line.

7. +++ b/core_search_facets/src/Tests/IntegrationTest.php
   @@ -0,0 +1,407 @@
   +      //'facet_source_id' => 'core_node_search:node_search',
   +      'facet_source_configs[core_node_search:node_search][field_identifier]' => 'type',
   

   Why is this in comment?

8. +++ b/core_search_facets/src/Tests/IntegrationTest.php
   @@ -0,0 +1,407 @@
   +    /*$this->assertRaw(t('Facet %name has been created.', ['%name' => $facet_name]));
   +    $this->assertUrl('admin/config/search/facets/' . $facet_id . '/display');
   +
   +    $this->drupalGet('admin/config/search/facets');*/
   

   Does this not work?

9. +++ b/core_search_facets/src/Tests/IntegrationTest.php
   @@ -0,0 +1,407 @@
   +
   

   Unneeded blank line

10. +++ b/core_search_facets/src/Tests/IntegrationTest.php
    @@ -0,0 +1,407 @@
    +    // @TODO Missing this text on local test. Not sure why.
    +    // $this->assertText($this->t('Are you sure you want to delete the facet'));
    +    // Actually submit the confirmation form.
    

    Can we figure out why this is, are the dependencies not calculated as expected?

11. +++ b/core_search_facets/src/Tests/WebTestBase.php
    @@ -32,11 +32,15 @@ abstract class WebTestBase extends SimpletestWebTestBase {
    +    'facets_query_processor',
    

    We don't need this module, I think.

12. +++ b/core_search_facets/src/Tests/WebTestBase.php
    @@ -61,18 +65,33 @@ abstract class WebTestBase extends SimpletestWebTestBase {
    +    // Adding 5 pages.
    

    Either change the comment or the number here, because it's not correct.

13. +++ b/core_search_facets/src/Tests/WebTestBase.php
    @@ -61,18 +65,33 @@ abstract class WebTestBase extends SimpletestWebTestBase {
    +    for($i = 0;$i < 10 ; $i++) {
    

    Coding standards, should be for ($i =0; $i < 10; $i++) {

14. +++ b/core_search_facets/src/Tests/WebTestBase.php
    @@ -61,18 +65,33 @@ abstract class WebTestBase extends SimpletestWebTestBase {
    +        'title' => 'foo bar',
    +        'body' => 'test page',
    

    Can we add the iterator's value to the title / body?
    'title' => 'foo bar: ' . $i

15. +++ b/core_search_facets/src/Tests/WebTestBase.php
    @@ -61,18 +65,33 @@ abstract class WebTestBase extends SimpletestWebTestBase {
    +    // Adding 5 articles.
    +    for($i = 0;$i < 10; $i++) {
    +      $this->drupalCreateNode(array(
    +        'title' => 'foo baz',
    +        'body' => 'test article',
    +        'type' => 'article',
    +      ));
    +    }
    

    see above.

Resolved my own issues, if this is green we can commit this and do the followup in #2655414: Avoid dependency on VIEWS module.

Thanks again for your contribution, committed. See you in the related issues for follow-ups.