Working on #2613186: Untangle the integration test from search api I've detected that we need to enable the views module because we call $views_storage = $this->entityTypeManager->getStorage('view'); from SearchApiViewsPageDeriver::getDerivativeDefinitions().

For core_search_module we don't need to activate views module. In this issue we need to avoid this dependency.

CommentFileSizeAuthor
#5 interdiff-2655414-3-5.txt703 bytesmarthinal
#5 2655414-5.patch1.69 KBmarthinal
#3 avoid_dependency_on-2655414-3.patch1.69 KBborisson_

Comments

marthinal created an issue. See original summary.

marthinal’s picture

marthinal commented
Issue summary: View changes
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new avoid_dependency_on-2655414-3.patch1.69 KB
marthinal’s picture

marthinal commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

Thanks!!

marthinal’s picture

marthinal commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2655414-5.patch1.69 KB
new interdiff-2655414-3-5.txt703 bytes

Quick fix

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Yep, that looks better, let's get this in.

marthinal’s picture

marthinal commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

  • marthinal committed 1495f42 on 8.x-1.x authored by borisson_ 
    Issue #2655414 by marthinal, borisson_: Avoid dependency on VIEWS module

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.