When a paragraph field is collapsed, required fields on the paragraph entity are not correctly validated.

Isn't this a copy of https://www.drupal.org/node/2558517 ?

I can confirm this issue, the attached patch fixes this by validating the submitted values on collapse.

My previous patch changed the wrong form builder property, here's a new one :-)

This is a different issue than https://www.drupal.org/node/2558517; in that issue, the requiredness of a paragraph item is not validated as required (so if I add a field "test" of type "paragraphs" and make it required, it does not throw an error if I do not add a paragraph item. This issue happens when one has a required field within the paragraph bundle (for example, paragraph bundle "p-test" has a required field of "label." If I add a field "test" of type "paragraphs" and set the open type to "preview" and then press "add paragraph item" and "collapse" and save, the p-test field is not actually required.

Tested the patch #4 and it does work. To test, I:

• Created a paragraph bundle with a required field
• Added a not-required field to my content type of type paragraphs
• Set the Default Edit Mode to "preview" to enable the collapse button
• Added a node, added a paragraph item, left the required field empty and pressed Collapse
• Verified that I see a "[field name] field is required" message when trying to collapse the paragraph item.

Thanks @Matthijs and @gadaniels72 for putting effort and time into this!

I'm currently trying to get the quality of the code up to par with the D8 version.
That mostly just means we need to add many tests to make sure we won't break anything.
Are you able to create a unit test for this? (and provide 2 patches: 1 with the fixed code + test, 1 with the test only. that way we can see the test actually confirms it is fixed now).

Tests added

Test failures are due to #2729173-2: Undefined property while creating new content, not anything to do with Paragraphs.

Patch #4 worked for me as well. Thanks!

@KarlShea seems like #2807275 is fixed, now to wait for Entity API to get updated.

Hi, the same bug exists on D8 version.

Re-queued tests from Patch #9 with success! Entity API patch has been committed #2807275

Hi,
please refer issue: https://www.drupal.org/project/paragraphs/issues/3065680

Unassigning supriya1992 from the issue.

The patch supplied in #4 worked well for me, and appears to have worked for folks given #14, #17, #6, so I'm marking this as reviewed & tested pending any major hiccups.

Attaching D8 version of this issue as a related task.

Patch committed to dev.