[D7] Commerce shipping GLS

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxirmantasp2606362git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello irmantasp,

Please look into the following:

.module file
1) In hook_menu you added the function comment twice, remove one.

2) Leave a blank line after hook_menu().

SUGGESTION
1) commerce_shipping_gls_service_rate() & commerce_shipping_gls_service_details_form() use standard doxygen to structure your comment

commerce_shipping_gls.admin.inc file
1) prefix you variable with module name, line 13.

2) write function to delete the variables defined by your module on uninstall.

Hey Irmantasp,

Please look into the following:

1) in commerce_shipping_gls.admin.inc you have variable named 'commerce_shipping_gls_shipping_rate_amount' (17 line), but you use 'gls_shipping_rate_amount' in commerce_shipping_gls_service_rate() line 69.

2) commerce_shipping_gls.admin.inc needs a separate comment for function so that code sniffer in http://pareview.sh/pareview/httpgitdrupalorgsandboxirmantasp2606362git would not find error.

3) commerce_shipping_gls.install needs @file comment.

4) comment "// Cache until next cc all." in commerce_shipping_gls.module 134 line is redundant.

5) You can use standard doxygen for commenting commerce_shipping_gls_service_rate() & commerce_shipping_gls_service_details_form() - https://www.drupal.org/node/1354 - that was a suggestion by atul4drupal.

Thanks for your contribution, Irmantas!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

I am giving credits to the users who participated in this issue.