Problem/Motivation

Follow-up for #2101427: Follow-up: Browser validation error with Chrome on hidden required fields, even on forms that don't allow client-side validation

We added some #states cruft to the installer to support an old version of Chrome. That version of chrome is long gone by now, so we can remove it again.

Proposed resolution

Remove #states form attribute from install database config form options.

Remaining tasks

Manual testing using Chrome

  1. Manually test the installer form with and without js enabled.
  2. Revert the changes from the above patch to the language add form and manually test that.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#32 patch.png64.54 KBlavanyatalwar
#19 interdiff.16-18.txt761 bytesspokje
#18 2565171-d10.x.18.patch1.48 KBspokje
#17 2565171-d10.x.17.patch1.3 KBspokje
#16 reroll_diff_2-16.txt1.7 KBakram khan
#16 2565171-16.patch991 bytesakram khan
#2 remove_installer_cruft-2565171-2.patch1.02 KBevilehk

Issue fork drupal-2565171

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

evilehk’s picture

evilehk commented
Issue summary: View changes
StatusFileSize
new remove_installer_cruft-2565171-2.patch1.02 KB

The commits from #2101427: Follow-up: Browser validation error with Chrome on hidden required fields, even on forms that don't allow client-side validation, f614976 and 5ab1bfc, also added a JavaScript required marker theme function to states.js and appended the marker to the field label if the field was required by the #states form attribute. Those lines have since been changed. In the end, I believe the revert is removing the #states attributes from the install database configuration form options. The patch is attached.

evilehk’s picture

evilehk commented
Status: Active » Needs review

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
akram khan’s picture

akram khan
Primary language English
Location Cuttack, Odisha
commented
StatusFileSize
new 2565171-16.patch991 bytes
new reroll_diff_2-16.txt1.7 KB

reroll against 9.4.x and address #15

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 2565171-d10.x.17.patch1.3 KB
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 2565171-d10.x.18.patch1.48 KB
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new interdiff.16-18.txt761 bytes

Hmmm, expected I would need separate patches for 9.x/10.x, but as it turns out one patch rules them all.

Added interdiff

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs manual testing

It could be good to determine if the way the installer database settings form works with and without JS enabled is as expected after this patch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Also looking at the original issue does this we can revert the changes it made to core/modules/language/lib/Drupal/language/Form/LanguageAddForm.php as well?

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

spokje’s picture

spokje
Primary language Dutch
commented

Also looking at the original issue does this we can revert the changes it made to core/modules/language/lib/Drupal/language/Form/LanguageAddForm.php as well?

@alexpott in #23

Not sure what changes? (But then again those old commits are hard to find in the issue)

smustgrave’s picture

smustgrave commented

So what's next steps needed for this @alexpott?

smustgrave’s picture

smustgrave commented
Status: Needs review » Postponed (maintainer needs more info)

For #23

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented

Following up if still a valid task?

catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed (maintainer needs more info) » Needs work

The change mentioned in #25 is the one from this patch afaict https://www.drupal.org/files/drupal8.forms-system.2101427-35.patch

That code is still the same, so I think it's still relevant.

I think next steps would be:

1. Convert the changes here to an MR
2. Manually test the installer form with and without js enabled.
3. Revert the changes from the above patch to the language add form and manually test that.

lavanyatalwar’s picture

lavanyatalwar commented

Looking into it

lavanyatalwar’s picture

lavanyatalwar commented
StatusFileSize
new patch.png64.54 KB

Hi @catch,
I reviewed both the patch and the current codebase. It seems the patch is based on an older version of the code, which has since changed significantly.
Could you please take a look and confirm?

nicxvan’s picture

nicxvan commented

It will need to be manually replicated.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone made their first commit to this issue’s fork.

quietone opened merge request !16458

quietone’s picture

quietone commented
Issue summary: View changes

I converted the patch in #18 to an MR. I updated the issue summary with the manual testing steps from #30.

quietone’s picture

quietone commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing +Needs Review Queue Initiative

Tested this on ddev with and without javascript disabled (used a Chrome browser extension for disabling)

The install worked just fine, unrelated to this change as I've been getting it for a while now but I do get a browser 404 on fresh installs. Talking to @catch and @nicxcan in slack if it's a bug actually.