Problem/Motivation

Although handy entity_load*() has been deprecated and is still used in core quite a bit. This issue only pertains to the block_content entity type.

Proposed resolution

Use instructions in the parent issue: #2359437: [meta] Remove entity_load* family of functions usage from the code base

Remaining tasks

Review and commit.

User interface changes

none

API changes

none

Data model changes

none

CommentFileSizeAuthor
#13 2549789-13.patch2.08 KBjofitz
#13 interdiff-11-13.txt1.5 KBjofitz
#11 2549789-11.patch2.14 KBgoogletorp
#7 2549789-7.patch2.01 KBrajeshwari10
block_content_deprecated.patch2.62 KBJaesin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jaesin created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Issue tags: +Needs beta evaluation

This function is only deprecated for 9.0.x, so it can still be used in 8.x.x, so I think this issue can be closed. At the very least it needs a beta phase evaluation template.

Jaesin’s picture

Jaesin CreditAttribution: Jaesin at Chapter Three commented

Probably better to postpone to 9.0.x rather than close but it brings up the question of weather these entity functions were marked deprecated a little early if we are not ready to start fixing them yet.

The way some IDE's display deprecated functions (talking about you PHPStorm ;P) is a little alarming when working on these classes.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Title: "\Drupal\block_content\Entity\BlockContent" is using the deprecated entity_load_multiple_by_properties » Remove entity_load* usage for block_content entity type
Version: 8.1.x-dev » 8.3.x-dev
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: -Needs beta evaluation +@deprecated
Parent issue: » #2359437: [meta] Remove entity_load* family of functions usage from the code base

Some usages of entity_load_multiple* for the block_content type remain.

Added parent #2359437: [meta] Remove entity_load* family of functions usage from the code base which is where we've handled all the others like this. See the instruction there for how to proceed.

rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions, Iksula commented
Assigned: Jaesin » rajeshwari10
rajeshwari10’s picture

rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions, Iksula commented
Assigned: rajeshwari10 » Unassigned
Status: Needs work » Needs review
FileSize
2549789-7.patch2.01 KB

Done changes on Drupal 8.3.x
Please Review.
Thanks.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

googletorp’s picture

googletorp CreditAttribution: googletorp as a volunteer and at Reveal IT commented
Status: Needs work » Needs review
FileSize
2549789-11.patch2.14 KB

Here is a reroll of the patch from #7.

Status: Needs review » Needs work

The last submitted patch, 11: 2549789-11.patch, failed testing. View results

jofitz’s picture

jofitz CreditAttribution: jofitz at ComputerMinds commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
interdiff-11-13.txt1.5 KB
2549789-13.patch2.08 KB

Correct errors in tests re-roll.

googletorp’s picture

googletorp CreditAttribution: googletorp as a volunteer and at Reveal IT commented
Status: Needs review » Reviewed & tested by the community

I don't see any usage of entity_load* in block module when patch is applied. All tests are green, code looks good.

I think this is RTBC.

  • larowlan committed a322311 on 8.5.x 
    Issue #2549789 by Jo Fitzgerald, Jaesin, rajeshwari10, googletorp:...

larowlan credited larowlan.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed a322311 and pushed to 8.5.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.