[meta] Remove entity_load* family of functions usage from the code base

I have put this issue to postponed, because the issue #2322639: Replace all instances of node_type_load(), node_type_get_types(), entity_load('node_type') and entity_load_multiple('node_type') with static method calls is not fixed. This issue removes all uses of node_type_get_types. It also removes the uses of node_type_load(), entity_load('node_type') and entity_load_multiple('node_type'). I think that is a good idea to remove those functions as well in this issue. So I am amending the issue title and summary.

@Mukeysh: The patch that you made only removes the function. It also has to remove the documentation that describes the function (Just above it).

During beta phase, it's unlikely these functions will be removed if they aren't already. The entity_*() ones aren't marked as deprecated: #2474151: Mark procedural wrappers in entity.inc as deprecated

@Mile23,

Those functions are deprecated for version 9.0 (https://www.drupal.org/node/2321969#comment-9867723).

There are still 13 calls to entity_load_multiple() and 155 calls to entity_load() in 8.x - moving back to there to remove the usages. Removing the function we can do with a single patch that removes dozens of other deprecated procedural wrappers.

https://api.drupal.org/api/drupal/core!includes!entity.inc/function/enti...

https://api.drupal.org/api/drupal/core!includes!entity.inc/function/enti...

#2322639: Replace all instances of node_type_load(), node_type_get_types(), entity_load('node_type') and entity_load_multiple('node_type') with static method calls has landed. So back to needs work.

More active I think, the patch doesn't remove usages of those two functions.

This should remove entity_load_multiple() and its usage

Looks beautiful and by removing the functions we now it works. The actual committable patch would have to leave the existing functions in until D9.

The one case in the patch that could use dependency injection instead of a call to \Drupal::entityTypeManager() is core/modules/views/src/Plugin/views/query/Sql.php but not sure we want to hold up the patch on that.

Some more...

1. +++ b/core/modules/language/src/Tests/LanguageConfigurationTest.php
   @@ -204,8 +204,10 @@ protected function checkConfigurableLanguageWeight($state = 'by default') {
        /* @var $languages \Drupal\Core\Language\LanguageInterface[] */
   -    $languages = entity_load_multiple('configurable_language', NULL, TRUE);
   +    $languages = $storage->loadMultiple();
        foreach ($languages as $language) {
   

   Needs to reset the cache.

2. +++ b/core/modules/node/node.module
   @@ -232,23 +232,6 @@ function node_mark($nid, $timestamp) {
   - * @deprecated in Drupal 8.x, will be removed before Drupal 9.0.
   - *   Use \Drupal\node\Entity\NodeType::loadMultiple().
   - *
   - * @see \Drupal\node\Entity\NodeType::load()
   - */
   -function node_type_get_types() {
   
   @@ -293,22 +276,6 @@ function node_type_get_description(NodeTypeInterface $node_type) {
   - * @deprecated in Drupal 8.x, will be removed before Drupal 9.0.
   - *   Use \Drupal\node\Entity\NodeType::load().
   - */
   -function node_type_load($name) {
   

   Leave these in because they're deprecated for removal in 9.

3. +++ b/core/modules/rest/src/Tests/CsrfTest.php
   @@ -84,7 +84,9 @@ public function testCookieAuth() {
   -    $this->assertFalse(entity_load_multiple($this->testEntityType, NULL, TRUE), 'No entity has been created in the database.');
   +    $storage = \Drupal::entityTypeManager()->getStorage($this->testEntityType);
   

   Use $this->container in all the tests, instead of \Drupal.

Going to submit "fuller" patch with entity_load() calls removed as well

Changes from the last patch (no sense in making interdiff, change is too big):

1. Remove usage of entity_load()
2. In tests, use container instead of \Drupal object
3. Following @todo in core/modules/comment/tests/src/Kernel/CommentDefaultFormatterCacheTagsTest.php, removed reset because #597236: Add entity caching to core is fixed

+++ b/core/includes/entity.inc
@@ -53,42 +53,6 @@ function entity_get_bundles($entity_type = NULL) {
- */
-function entity_load($entity_type, $id, $reset = FALSE) {
-  $controller = \Drupal::entityManager()->getStorage($entity_type);

As mentioned these hunks should be dropped from the patch - actual removal is 9.x

Didn't do a full review of the patch, but what I did review looked good.

Bring back entity_load() and entity_load_multiple() declarations - only replacing \Drupal->entityManager() with \Drupal->entityTypeManager()

Stupid typo

Declare config_test_no_status as a separately annotated class to avoid AmbiguousEntityClassException

It looks like using $this->container instead of global \Drupal object causes a lot of problems. The patch is already big enough, can the issue be split up? It can be replacing usage of entity_load() / entity_load_multiple() from "the base code", and then the same for the tests

Add entity_load_multiple_by_properties() and entity_load_unchanged() to the list of functions calls to which should be removed

Splitting into tests and non-tests sounds fine.

@catch: awesome!
non-test patch has been submitted in a child issue #2721771: Remove entity_load_multiple(), entity_load(), entity_load_unchanged() and entity_load_multiple_by_properties() usages from the code base (non-tests), and passes tests.

I'm not sure about the scope suggested in #29. Can't we just have an issue per function - because this makes things really easy to review.

@alexpott, as you suggested in #2721771: Remove entity_load_multiple(), entity_load(), entity_load_unchanged() and entity_load_multiple_by_properties() usages from the code base (non-tests), I start filing subissues based on entity type / module (not function, cause that's make patches unreasonably big and hard to review)

Change status to Active, and unassign myself

Patch for sub issue Remove entity_load* usage for 'editor' entity type (https://www.drupal.org/node/2723587).

Errantly uploaded patch to wrong issue. Restoring status to needs work.

Back to 'Active'

Bumping version (no need for backport)

New child issue: #2549789: Remove entity_load* usage for block_content entity type

See #3027178-5: Properly deprecate entity_load_multiple_by_properties() we should have issues scoped to each method and add @trigger_error() to each method. The issue summary needs a bit of an update.

Added #3028657: Properly deprecate entity_load_multiple()

Looks like we are done here, thanks everyone who helped!

The leftover is RTBC already #3051069: Remove usage of deprecated entity_delete_multiple in core and trigger an error