Remove usage of deprecated entity_delete_multiple in core and trigger an error

1. +++ b/core/modules/comment/tests/src/Functional/CommentNodeChangesTest.php
   @@ -27,7 +27,7 @@ public function testNodeDeletion() {
        $this->assertNotNull(FieldConfig::load('node.article.comment'), 'Comment field exists');
        // Delete the node type.
   -    entity_delete_multiple('node_type', [$this->node->bundle()]);
   +    \Drupal::entityTypeManager()->getStorage('node_type')->load($this->node->bundle())->delete();
        $this->assertNull(FieldStorageConfig::load('node.comment'), 'Comment field storage deleted');
   

   $this->node->get('type')->entity->delete() should work too for this.

   The whole thing is a bit weird though, was $this->node already deleted?

2. +++ b/core/modules/shortcut/tests/src/Functional/ShortcutLinksTest.php
   @@ -290,7 +290,8 @@ public function testShortcutLinkDelete() {
        // Delete all the remaining shortcut links.
   -    entity_delete_multiple('shortcut', array_filter($ids));
   +    $storage = $this->container->get('entity_type.manager')->getStorage('shortcut');
   +    $storage->delete($storage->loadMultiple(array_filter($ids)));
   

   why sometimes $this->container and sometimes \Drupal::entityTypeManager(), I'd always use the second.

3. +++ b/core/modules/taxonomy/tests/src/Kernel/TermKernelTest.php
   @@ -31,7 +31,6 @@ protected function setUp() {
    
      /**
       * Deleting terms should also remove related vocabulary.
   -   * Deleting an invalid term should silently fail.
       */
      public function testTermDelete() {
        $vocabulary = $this->createVocabulary();
   @@ -40,9 +39,6 @@ public function testTermDelete() {
   
   @@ -40,9 +39,6 @@ public function testTermDelete() {
        $valid_term->delete();
        $terms = entity_load_multiple_by_properties('taxonomy_term', ['vid' => $vocabulary->id()]);
        $this->assertTrue(empty($terms), 'Vocabulary is empty after deletion');
   -
   -    // Delete an invalid term. Should not throw any notices.
   -    entity_delete_multiple('taxonomy_term', [42]);
      }
   

   I'm not sure what this is testing, but that description is weird. We definitely don't delete vocabularies when you delete terms, what it is testing is that there are no other terms in that vocabulary, not sure what the point of that is though.

4. +++ b/core/modules/user/user.module
   @@ -879,7 +879,9 @@ function user_delete($uid) {
     */
    function user_delete_multiple(array $uids) {
   -  entity_delete_multiple('user', $uids);
   +  $user_storage = \Drupal::entityTypeManager()->getStorage('user');
   +  $users = $user_storage->loadMultiple($uids);
   

   lets just @deprecate this function too?

Personally I use \Drupal::service in Functional and Javascript tests and $this->container in kernel tests for absolutely no justifiable reason

There is a reason this is a logical approach. $this->container is maintained in kernel tests to be in-sync with the real container - there is a listener that keeps it updated. In Functional tests \Drupal is updated more often than $this->container (both however are not great - but \Drupal looks worse and therefore is preferable because it reminds us we're doing something we shouldn't :) )

Just one tit bit.

+++ b/core/includes/install.core.inc
@@ -1698,7 +1698,10 @@ function install_download_additional_translations_operations(&$install_state) {
+      $en = ConfigurableLanguage::load('en');
+      if ($en) {
+        $en->delete();

Variable name is not correct and it can be one line if($lang= ConfigurableLanguage::load('en'));.

Thanks!

Committed c210fad and pushed to 8.8.x. Thanks!