Parent Issue

#2359437: [meta] Remove entity_load* family of functions usage from the code base

Problem/Motivation

There are cases where entities of the editor entity type are retrieved using the functional loader, entity_load*()

Proposed resolution

Replace calls to entity_load*('editor', ...) with Editor::load*()

CommentFileSizeAuthor
#11 interdiff.txt632 bytessnehi
#11 2723587-10.patch8.71 KBsnehi
#7 interdiff-2723587-4-7.txt8.04 KBmarvin_b8
#7 2723587-7.patch8.1 KBmarvin_b8
#4 2723587-4.patch8.74 KBBeau Townsend

Comments

valthebald created an issue. See original summary.

valthebald’s picture

valthebald
Location Sofia
commented

See #2359437: [meta] Remove entity_load* family of functions usage from the code base

Beau Townsend’s picture

Beau Townsend commented

Working on removing & replacing instances of deprecated entity_load* 'editor' functions.

Beau Townsend’s picture

Beau Townsend commented
Status: Active » Needs review
StatusFileSize
new 2723587-4.patch8.74 KB

Patch for above issue.

valthebald’s picture

valthebald
Location Sofia
commented
Status: Needs review » Needs work

For entity_load('editor') in tests, please use Editor::load() - it's shorter, and usage of global \Drupal object in tests is discourageed

The last submitted patch, 4: 2723587-4.patch, failed testing.

marvin_b8’s picture

marvin_b8 commented
Status: Needs work » Needs review
StatusFileSize
new 2723587-7.patch8.1 KB
new interdiff-2723587-4-7.txt8.04 KB
john cook’s picture

john cook commented
Status: Needs review » Needs work

After applying the patch there is still one more use of functional loading:

core/modules/editor/editor.module:252:  $editors = entity_load_multiple('editor');

Editor::loadMultiple() can be used to retrieve multiple entities.

john cook’s picture

john cook commented
Issue summary: View changes

Updated summary.

marvin_b8’s picture

marvin_b8 commented
Status: Needs work » Needs review
StatusFileSize
new 2723587-10.patch8.71 KB
new interdiff-2723587-7-10.txt546 bytes
snehi’s picture

snehi commented
StatusFileSize
new 2723587-10.patch8.71 KB
new interdiff.txt632 bytes

Done.

snehi’s picture

snehi commented

Same timing for Patch coincidence :)

The last submitted patch, , failed testing.

Status: Needs review » Needs work

The last submitted patch, 11: 2723587-10.patch, failed testing.

john cook’s picture

john cook commented
Status: Needs work » Reviewed & tested by the community

The patches in comments #10 and #11 contain the same changes.

After applying patch #11 there were no more calls to entity_load*() for the editor entity type.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 2723587-10.patch, failed testing.

john cook’s picture

john cook commented
Status: Needs work » Reviewed & tested by the community

The testbot has passed #11, so setting back to RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

  • catch committed 4c4a039 on 8.2.x 
    Issue #2723587 by marvin_B8, snehi, Beau Townsend, valthebald, John Cook...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: entity system » editor.module

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.