Closed (works as designed)
Project:
Drupal core
Version:
8.9.x-dev
Component:
install system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Aug 2015 at 09:39 UTC
Updated:
17 Aug 2020 at 23:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hron84 commentedComment #3
othermachines commentedAdding related Issue #2560123: Cache DatabaseBackend depends on mbstring which resolves the error where it occurs rather than adding mbstring to the requirements.
Comment #5
mile23Comment #7
gnugetmb_check_encoding is optional, we can not just include it in the requirements.
Check #2560123 for more details.
I think we can use the Symfony mbstring polyfill
vendor/symfony/polifill-mbstring/Mbstringto fix this without needing to require mbstring.Comment #11
alexpottThis is odd we already have the Symfony polyfill ... vendor/symfony/polyfill-mbstring/bootstrap.php should be loaded as part of vendor/composer/autoload_files.php on every request.
Comment #12
berdirThere is a reason this issue hasn't been updated since 2015 (not in the way of someone reporting to see this problem). I'm pretty sure it doesn't happen anymore since we have the polyfill. With #2849669: Fix \Drupal\Component\Utility\Unicode() because of the Symfony mbstring polyfill, this is no longer a bug but instead it is now already ahead of everything else in core :)
"Closed (used to be a bug but now it is a feature)" :)
Comment #13
mile23Well, it's a little interesting...
We don't require mbstring for D8 but we do test with it present in the testbot: https://cgit.drupalcode.org/drupalci_environments/tree/php/7.0-apache/Do...
Which means we don't exercise the polyfill during tests, so we have no coverage for them.
So even though this issue is probably fine being closed, it's impossible to prove that it should be.
We should probably
suggestthe extensions we test for incore/composer.json. That would also include PECL YAML and the others in the testbot environment builder linked above.Comment #17
larowlanYeah, twig requires the mbstring polyfill, so I think we're fine here now