[D7] Allow image fields to use any extensions the current image toolkit supports (instead of hard-coding jpg, png and gif only)

Please see if this is an issue in Drupal 8. If it is, then move this to version 8.0.x where it can be fixed, then backported.

Patch #3 is working with Drupal 7.39 (and Media 2.0-beta1).

There is an issue for Drupal 8:
#2541480: Allow SVG files in the image widget

By GD (our default image toolkit) does not support SVG. So you cannot generate image styles of them. I think we should close this in favor of #1014816: Allow image fields to use any extensions the current image toolkit supports (instead of hard-coding jpg, png and gif only).

So this issue should a feature request for Drupal 8 with an backport to Drupal 7 or SVG files should defined as files and not as images (Working in Drupal 8 beta 15 with patched #1014816 ).

#2 patch is not working with core image field of content type. It is showing error at the time of upload .svg type image. So I am adding new patch for above issue.

This is a duplicate of #1014816: Allow image fields to use any extensions the current image toolkit supports (instead of hard-coding jpg, png and gif only). Postponing this issue on it, per the backport policy.

The patch mentioned in #6 does not work with Drupal 7.44. Any pointers on a more recent working patch?

I get the following error when I try to patch in Mac OSX....

$ patch < drupal-add_basic_svg_support-2539478-3-D7.patch
can't find file to patch at input line 5
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/modules/image/image.admin.inc b/modules/image/image.admin.inc
|index cebe894..11125df 100644
|--- a/modules/image/image.admin.inc
|+++ b/modules/image/image.admin.inc
--------------------------
File to patch: /modules/image/image.admin.inc
/modules/image/image.admin.inc: No such file or directory
Skip this patch? [y] n
File to patch: modules/image/image.admin.inc
patching file modules/image/image.admin.inc
can't find file to patch at input line 22
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/modules/image/image.field.inc b/modules/image/image.field.inc
|index 6d1867c..822ad2e 100644
|--- a/modules/image/image.field.inc
|+++ b/modules/image/image.field.inc
--------------------------

You must be in Drupal's root directory when you apply a core patch.

I got SVGs working by going to configurations->text formats->configure full html and disabling "Convert line breaks into HTML (i.e.
and

)". I then pasted the entire

the body field as Source and it worked. The only issue is that you have to disable the Convert everything you push code up to the server.

#6 works great.
It does look like a workaround, and not a core valid solution, but I have no complaints! :)

I had to change it a little bit to support custom SVG image effects (we are using it to change the SVG fill color for example), the change to the patch is only on the image.module file:

  $is_svg = ($image->info['extension'] == 'svg');
  foreach ($style['effects'] as $effect) {
    if ($is_svg && empty($effect['svg_support'])) {
      continue;
    }

    image_effect_apply($image, $effect);
  }

And the custom image effect looks like this (note the svg_support attribute I created):

/**
 * Implements hook_image_effect_info().
 */
function svg_effects_image_effect_info() {
  $effects = array(
    'svg_effects_fill' => array(
      'label' => t('SVG fill'),
      'help' => t('Change the SVG fill color.'),
      'effect callback' => 'svg_effects_fill_effect',
      'form callback' => 'svg_effects_fill_form',
//      'summary theme' => 'image_scale_summary',
      'svg_support' => TRUE
    )
  );

  return $effects;
}

Thanks :)

Now that #1014816: Allow image fields to use any extensions the current image toolkit supports (instead of hard-coding jpg, png and gif only) is in Drupal 8, we can re-open this I assume.

It would be great if the .ico extension also worked

Hi,

Can somebody commit this to drupal core since #6 is working as expected!
Because everytime we update the core, this patch is lost and have to manually apply it all again.
It will be great if somebody can commit this to drupal core

Thanks in advance.

Setting proper issue status. It's certainly not fixed, but if anybody wants to RTBC this … (haven't reviewed the patch myself).

Bumping to 7.68.

Updated the patch. This patch working in latest Drupal core.

Removed space in the patch file name.

Updated the patch. This patch working in latest Drupal 7.67 core.

I don't know if this patch is still needed, but the latest no longer applies, so here's a re-roll for anyone still on 7.x.

This may be nit-picking, not only is the title of this issue rather long but it also doesn't seem to be entirely accurate or provide clarity on what the issue and patch do.

"Allow image fields to use any extensions the current image toolkit supports (instead of hard-coding jpg, png and gif only)"

Looking at the patch it appears that the allowed extensions are still hard coded and the only difference is the addition of svg formats.

Would the following title be more suitable? "Add svg to image fields to match all extensions image toolkit supports"

Added this issue to #3216978: [meta] Priorities for 2021-12-01 release of Drupal 7 in anticipation of that issue being rolled over into a new issue of priorities for the next release of D7 core.

I also agree with @izmeez that the title of this issue is a bit misleading. If we want to allow any extension, then we need to implement the backport of the #1014816: Allow image fields to use any extensions the current image toolkit supports (instead of hard-coding jpg, png and gif only). This will ensure that all image toolkits will be able to define supported extensions and also handle them in particular functions.

Hardcoding the SVG into many places does not seems a good idea to me, mainly because GD does not support SVG, so it rather needs to be added to another image toolkit (see D8/9 status of the SVG support).

If we go this way, image toolkits will be able to allow different extensions (as in D8) and then the followup issues can extend support for these extensions in the tookits (for example like this: #3179554: [D7] Add webp support for core image module.

I have attached a patch which should backport #1014816: Allow image fields to use any extensions the current image toolkit supports (instead of hard-coding jpg, png and gif only), but still preserves the default extensions if there is another image toolkit in use, which does not currently implements the new get_supported_extensions() function. Let's see what testbot says.

Adding some related issues probably worth checking also (especially if we want to make this generic, like the last proposed patch).

I don't see this getting into D7, can we get it in d10 or 11?

AVIF & WebP look ready to roll though:
https://caniuse.com/?search=avif
https://caniuse.com/?search=webp

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

@mgifford this is a D7 backport issue. The original issue is here: #1014816: Allow image fields to use any extensions the current image toolkit supports (instead of hard-coding jpg, png and gif only) and was fixed 6 years ago, so it should be in D10+ already.

Since the last patch no longer applies to the 7.x branch, I created a MR.