Add PHPUnit test for making sure that the class variables of all subclasses of ConfigEntityBase and ContentEntityBase are protected or are allowed to be public.

CommentFileSizeAuthor
#25 2527114-nr-bot.txt1.87 KBneeds-review-queue-bot
#20 interdiff_19-20.txt2.45 KBsuresh prabhu parkala
#20 2527114-20.patch3.9 KBsuresh prabhu parkala
#19 2527114-19.patch3.97 KBkarishmaamin
#7 2527114-7.patch3.97 KBdaffie
#3 2527114-3.patch4.81 KBdaffie
#3 interdiff-2527114-2-3.txt651 bytesdaffie
#2 2527114-2.patch4.81 KBvijaycs85
#2 2527114-diff-1-2.txt6.21 KBvijaycs85
#1 2527114-1.patch4.69 KBdaffie

Comments

daffie’s picture

daffie commented
Status: Active » Needs review
StatusFileSize
new 2527114-1.patch4.69 KB
vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new 2527114-diff-1-2.txt6.21 KB
new 2527114-2.patch4.81 KB

Looks good. Fixed some code style issues and renamed the class.

daffie’s picture

daffie commented
StatusFileSize
new interdiff-2527114-2-3.txt651 bytes
new 2527114-3.patch4.81 KB

Fixed one minor nitpick. All the changes from the patch from comment #2 are RTBC from me.

@vijaycs85: If you think my part is also RTBC, then please change the status to RTBC. And thank you for your help. :-)

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Reviewed & tested by the community

Thanks @daffie. Looks good to me. Since I made very minor code style changes, it's OK for me to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented 
+++ b/core/modules/system/tests/src/Unit/Entity/EntityPropertiesVisibilityTest.php
@@ -0,0 +1,115 @@
+      [['id', 'label'], 'Drupal\Core\Datetime\Entity\DateFormat'],

These are now protected.

Also the problem with this type of test is that it only helps core - but actually it would be good if contrib could also benefit from this sort of testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
daffie’s picture

daffie commented
Status: Needs work » Needs review
StatusFileSize
new 2527114-7.patch3.97 KB

Changed the test in the way that alexpott wants.

I did not add an interdiff.txt file because of all the changes.

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/system/src/Tests/Entity/EntityPropertiesVisibilityTest.php
@@ -0,0 +1,90 @@
+    ['class' => 'Drupal\node\Entity\Node', 'variable' => 'in_preview'],
...
+      DRUPAL_ROOT . '/modules',

I just disagree that contrib code should not be allowed to have public properties, examples like in_preview show that there are usecase, potentially.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

Needs work given #8 :)

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 8.9.x-dev » 9.3.x-dev
karishmaamin’s picture

karishmaamin commented
Status: Needs work » Needs review
StatusFileSize
new 2527114-19.patch3.97 KB

Re-rolled patch for 9.3.x-dev. Please review

suresh prabhu parkala’s picture

suresh prabhu parkala commented
StatusFileSize
new 2527114-20.patch3.9 KB
new interdiff_19-20.txt2.45 KB

Tried to fix custom failures. Please review.

andypost’s picture

andypost
he/him
Primary language Russian
commented 
+++ b/core/modules/system/src/Tests/Entity/EntityPropertiesVisibilityTest.php
@@ -0,0 +1,86 @@
+// The variable Vocabulary::hierarchy has a default value of
+// TAXONOMY_HIERARCHY_DISABLED. The problem is that this constant is defined in
+// the file taxonomy.module.
+include DRUPAL_ROOT . '/core/modules/taxonomy/taxonomy.module';

Please create follow-up (can't find existing issue) to move this constant into VocabularyInterface

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 2527114-nr-bot.txt1.87 KB

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.