[D7] Text to Image

Hi ,
Please fix below Points:

1)Provide proper Git clone command:
Please follow instructions:
You can find the correct git clone command for your sandbox by clicking on the Version control tab, removing the checkbox in front of "Maintainer", and clicking Show. You can then copy-paste the git clone command from the codeblock below "Setting up repository for the first time".
2) PHP ERROR:
Can't use function return value in write context in ./text_to_image.module on line 96
Errors parsing ./text_to_image.module
Please fix if not fixed already.
3)GIT ERROR:
It appears you are working in the "7.x.1.x" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Reference Link: https://www.drupal.org/node/1127732

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

As identified by pareview.sh:
Review of the 7.x.1.x branch (commit 05f0c10):

- Remove "version" from the ./text_to_image.info file, it will be added by drupal.org packaging automatically.
- PHP Fatal error: Can't use function return value in write context in ./text_to_image.module on line 96
Errors parsing ./text_to_image.module
- No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

No Does not follow the guidelines for 3rd party assets/code. An included font in fonts/msjh.ttf is (c) Microsoft Corp. and doesn't seem to have a GPLv2 compatible license. Reference

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdilipsingh022511972git

I'm a robot and this is an automated message from Project Applications Scraper.

Manual review:
Git errors:
It appears you are working in the "7.x.1.x" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
1) text_to_image_admin_settings() line 59 wrap a string in a function t();
2) instead of the public: // use file_default_scheme()

Hi,

Please set the default git branch in settings. Current git clone url is not working. While unpack the package the operation is breaking.

Thanks,
ARUN AK

Hi Dilip,

Coder shows following critical warnings in text_to_image.install file:

1. (*) Line 24: Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs) [security_dsm]
   drupal_set_message($msg, 'error');
2. (*) Line 29: Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs) [security_dsm]
   drupal_set_message($msg, 'warning');

If you review a project and it contains a file called License.txt, there is probably something wrong.

http://cgit.drupalcode.org/sandbox-dilipsingh02-2511972/tree/fonts/Aller...

All rights not expressly granted in the EULA are expressly reserved
to Dalton Maag. The Licensee may not use the Font Software to electronically
distribute a Digital Product without a separate licence from Dalton Maag
authorizing the Licensee to do so.

WTF?!? This font needs to be deleted immediately!

I can't believe there are other manual reviews of this project that didn't point this out.

> 3 weeks with no response. Escalated #2569885: Commerically licensed font in Text to Image project to have the sandbox node unpublished, the non-GPLv2 files deleted from git and @dilipsingh02's git access revoked.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.