My entity has a datetime field depending on the datetime module.
that means in $entity->precreate I'm setting a default time:
$values['mydatetimefield'] = 'some value'//I think DrupalDateTime::createFromArray(['year'=> 1980, 'month'=> 8, 'day' => 8]);
This value however is not set in $items->setValue() because in FieldItembase::setValue() it looks for the first property name $keys[0], which is 'value' (as defined in DateTimeItem::propertyDefinitions).
However in DateTimeWidgetBase::formElement, it expects the other property, 'date' to be populated.
Consequently, $items->getValue() isEmpty, because $values['date'] is not set;

Its a bit of a mess but that's the best I can report at the moment...

CommentFileSizeAuthor
#10 2507775-10-TEST-ONLY.patch3.27 KBjhedstrom

Comments

matslats’s picture

matslats commented

PS I've also tried setting the basefield property like this:

BaseFieldDefinition::create('datetime')
      ->setDefaultValueCallback('expiresDefault');

Then

public static function expiresDefault() {
  $interval = \Drupal::config('smallads.conf')->get('default_expiry');
  //its not clear to me what format this function should return
  return DrupalDateTime::createFromTimestamp(strtotime($interval));
}
handkerchief’s picture

handkerchief
Primary language German
Location Chur, Switzerland
commented

i can't set a default value like this:

$form['date_field'] = array(
    '#type' => 'datetime',
    '#default_value' => \Drupal\Core\Datetime\DrupalDateTime::createFromTimestamp(time()),
    '#title' => $this->t('Some title'),      
  );

Is this a bug or am i doing it wrong?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

Does the fix over in #2778083: Default value for Date-Only fields is broken when UTC date is different than user current date address this?

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

hatuhay’s picture

hatuhay commented

Any news on this one.
I am trying:

  /**
   * {@inheritdoc}
   */
  public static function preCreate(EntityStorageInterface $storage_controller, array &$values) {
    parent::preCreate($storage_controller, $values);
    $values += array(
      'user_id' => \Drupal::currentUser()->id(),
      'loan_date' => DrupalDateTime::createFromTimestamp(time()),
    );
  }

and

    $fields['loan_date'] = BaseFieldDefinition::create('datetime')
      ->setLabel(t('Loan Date'))
      ->setDescription(t('The date the book was loanned.'))
      ->setRequired(true)
      ->setRevisionable(true)
      ->setDefaultValueCallback('todayDatetime')
...
  /**
   * {@inheritdoc}
   */
  public function todayDatetime() {
    return DrupalDateTime::createFromTimestamp(time());
  }

No success

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
StatusFileSize
new 2507775-10-TEST-ONLY.patch3.27 KB

This adds a passing test. It doesn't try to set the value to a datetime object as posted above, but works. This test fails if an object is used instead of a string, as there is nothing in the datetime field to translate that back before it attempts to save to the db.

So there may be an issue here in that default values cannot be set as DrupalDateTime objects, so we could either resolve that somehow, or update the documentation...

Status: Needs review » Needs work

The last submitted patch, 10: 2507775-10-TEST-ONLY.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

I'm trying to add created & changed columns to Commerce Store entity. This issue has been a bummer. Trying to run sql update query to workaround this.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Needs work » Closed (outdated)
Issue tags: +Bug Smash Initiative

I think is outdated as of #2830094: Deprecate and remove usages of datetime_date_default_time().. That issue also added tests and documentation.

If I am wrong, re-open the issue.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.