Problem/Motivation

Drupal\Core\StreamWrapper\LocalStream::stream_metadata() calls clearstatcache(). This is somewhat helpful for people using stream wrappers, but it is inconsistent with how PHP's regular file handling works. This can lead to bugs where someone depends on the stream wrapper behavior, but then deals with a regular file.

Proposed resolution

Remove the clearstatcache() call.

Remaining tasks

Get consensus.

User interface changes

None.

API changes

Minor. Local stream wrappers now behave more like the regular file system.

CommentFileSizeAuthor
#24 2501719-24.patch1.72 KBsmustgrave
#24 interdiff-10-24.txt3.14 KBsmustgrave
#10 remove-clearstatcache-2501719-10.patch1.78 KBnitesh pawar
#7 remove-clearstatcache-2501719-7.patch1.5 KBnitesh pawar
#3 remove-clearstatcache-2501719-2.patch1.47 KBmandar.harkare
#1 2501719-1-remove-clearstatcache.patch1.47 KBtwistor

Issue fork drupal-2501719

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

twistor’s picture

twistor commented
Status: Active » Needs review
StatusFileSize
new 2501719-1-remove-clearstatcache.patch1.47 KB

Let's see what breaks.

Status: Needs review » Needs work

The last submitted patch, 1: 2501719-1-remove-clearstatcache.patch, failed testing.

mandar.harkare’s picture

mandar.harkare commented
StatusFileSize
new remove-clearstatcache-2501719-2.patch1.47 KB

Adding same patch again.

mandar.harkare’s picture

mandar.harkare commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: remove-clearstatcache-2501719-2.patch, failed testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Assigned: twistor » Unassigned
nitesh pawar’s picture

nitesh pawar commented
StatusFileSize
new remove-clearstatcache-2501719-7.patch1.5 KB

ltl optimized

nitesh pawar’s picture

nitesh pawar commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: remove-clearstatcache-2501719-7.patch, failed testing.

nitesh pawar’s picture

nitesh pawar commented
Status: Needs work » Needs review
StatusFileSize
new remove-clearstatcache-2501719-10.patch1.78 KB

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Version: 9.4.x-dev » 10.1.x-dev

lets see if patch passes 10.1

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Patch failed to apply to 10.1 so needs some work.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-10-24.txt3.14 KB
new 2501719-24.patch1.72 KB

Rerolled for 10.1

gaurav-mathur’s picture

gaurav-mathur commented

Patch #24 applied successfully on drupal version 10.1.x
Thank you

Rashmisoni made their first commit to this issue’s fork.

Rashmisoni opened merge request !3479

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update 
+++ b/core/lib/Drupal/Core/StreamWrapper/LocalStream.php
@@ -243,37 +243,34 @@ public function stream_cast($cast_as) {
 
       case STREAM_META_ACCESS:
         $return = chmod($target, $value);
+        if ($return) {
+          // For convenience clear the file status cache of the underlying file,
+          // since metadata operations are often followed by file status checks.
+          clearstatcache(TRUE, $target);
+          return TRUE;
+        }
         break;

The issue title and summary says remove the call, but this is moving it around - can we not remove it entirely?

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.