Remove clearstatcache() call from LocalStream. [#2501719]

Problem/Motivation

Drupal\Core\StreamWrapper\LocalStream::stream_metadata() calls clearstatcache(). This is somewhat helpful for people using stream wrappers, but it is inconsistent with how PHP's regular file handling works. This can lead to bugs where someone depends on the stream wrapper behavior, but then deals with a regular file.

Proposed resolution

Remove the clearstatcache() call.

Remaining tasks

Get consensus.

User interface changes

None.

API changes

Minor. Local stream wrappers now behave more like the regular file system.

Comment	File	Size	Author
#24	2501719-24.patch	1.72 KB	smustgrave
#24	10.1.x: PHP 8.1 & MySQL 5.7 28,483 pass
#24	interdiff-10-24.txt	3.14 KB	smustgrave
#10	remove-clearstatcache-2501719-10.patch	1.78 KB	Nitesh Pawar
#10	8.0.x: PHP 5.5 & MySQL 5.5 14,214 pass 10.1.x: PHP 8.1 & MySQL 5.7 Custom Commands Failed
#7	remove-clearstatcache-2501719-7.patch	1.5 KB	Nitesh Pawar
#7	8.0.x: PHP 5.5 & MySQL 5.5 14,212 pass, 2 fail
#3	remove-clearstatcache-2501719-2.patch	1.47 KB	mandar.harkare
#3	8.0.x: PHP 5.5 & MySQL 5.5 13,299 pass, 2 fail
#1	2501719-1-remove-clearstatcache.patch	1.47 KB	twistor
#1

Issue fork drupal-2501719

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2501719-remove-clearstatcache-call changes, plain diff MR !3479
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

twistor CreditAttribution: twistor commented 6 June 2015 at 18:12

Status:

Active

» Needs review

File	Size
2501719-1-remove-clearstatcache.patch	1.47 KB

Let's see what breaks.

Comment #2

6 June 2015 at 18:35

Status:

Needs review

» Needs work

The last submitted patch, 1: 2501719-1-remove-clearstatcache.patch, failed testing.

Comment #3

mandar.harkare CreditAttribution: mandar.harkare as a volunteer and commented 18 August 2015 at 10:16

File	Size
remove-clearstatcache-2501719-2.patch	1.47 KB
8.0.x: PHP 5.5 & MySQL 5.5 13,299 pass, 2 fail

Adding same patch again.

Comment #4

mandar.harkare CreditAttribution: mandar.harkare as a volunteer and commented 18 August 2015 at 10:19

Status:

Needs work

» Needs review

Comment #5

18 August 2015 at 10:45

Status:

Needs review

» Needs work

The last submitted patch, 3: remove-clearstatcache-2501719-2.patch, failed testing.

Comment #6

mgifford

he/him

English

CreditAttribution: mgifford at OpenConcept Consulting Inc. commented 9 October 2015 at 00:29

Assigned:

twistor

» Unassigned

Comment #7

Nitesh Pawar CreditAttribution: Nitesh Pawar at Trigyn Technologies Ltd commented 9 October 2015 at 09:54

File	Size
remove-clearstatcache-2501719-7.patch	1.5 KB
8.0.x: PHP 5.5 & MySQL 5.5 14,212 pass, 2 fail

ltl optimized

Comment #8

Nitesh Pawar CreditAttribution: Nitesh Pawar at Trigyn Technologies Ltd commented 9 October 2015 at 09:56

Status:

Needs work

» Needs review

Comment #9

9 October 2015 at 10:27

Status:

Needs review

» Needs work

The last submitted patch, 7: remove-clearstatcache-2501719-7.patch, failed testing.

Comment #10

Nitesh Pawar CreditAttribution: Nitesh Pawar at Trigyn Technologies Ltd commented 9 October 2015 at 12:34

Status:

Needs work

» Needs review

File	Size
remove-clearstatcache-2501719-10.patch	1.78 KB
8.0.x: PHP 5.5 & MySQL 5.5 14,214 pass 10.1.x: PHP 8.1 & MySQL 5.7 Custom Commands Failed

File

Size

remove-clearstatcache-2501719-10.patch

1.78 KB

8.0.x:
PHP 5.5 & MySQL 5.5 14,214 pass

10.1.x:
PHP 8.1 & MySQL 5.7 Custom Commands Failed

Comment #11

9 October 2015 at 12:34

Version:

8.0.x-dev

» 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #12

9 October 2015 at 12:34

Version:

8.1.x-dev

» 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #13

9 October 2015 at 12:34

Version:

8.2.x-dev

» 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #14

9 October 2015 at 12:34

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #15

9 October 2015 at 12:34

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #16

9 October 2015 at 12:34

Version:

8.5.x-dev

» 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #17

9 October 2015 at 12:34

Version:

8.6.x-dev

» 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #18

9 October 2015 at 12:34

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #19

9 October 2015 at 12:34

Version:

8.9.x-dev

» 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #20

9 October 2015 at 12:34

Version:

9.2.x-dev

» 9.3.x-dev

Comment #21

9 October 2015 at 12:34

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #22

smustgrave CreditAttribution: smustgrave at Mobomo commented 25 November 2022 at 17:56

Version:

9.4.x-dev

» 10.1.x-dev

lets see if patch passes 10.1

Comment #23

smustgrave CreditAttribution: smustgrave at Mobomo commented 25 November 2022 at 18:57

Status:

Needs review

» Needs work

Patch failed to apply to 10.1 so needs some work.

Comment #24

smustgrave CreditAttribution: smustgrave at Mobomo commented 28 November 2022 at 19:11

Status:

Needs work

» Needs review

File	Size
interdiff-10-24.txt	3.14 KB
2501719-24.patch	1.72 KB
10.1.x: PHP 8.1 & MySQL 5.7 28,483 pass

4 files were hidden/shown/deleted

File	Size
2501719-1-remove-clearstatcache.patch	1.47 KB

remove-clearstatcache-2501719-2.patch	1.47 KB
8.0.x: PHP 5.5 & MySQL 5.5 13,299 pass, 2 fail
remove-clearstatcache-2501719-7.patch	1.5 KB
8.0.x: PHP 5.5 & MySQL 5.5 14,212 pass, 2 fail
remove-clearstatcache-2501719-10.patch	1.78 KB
8.0.x: PHP 5.5 & MySQL 5.5 14,214 pass 10.1.x: PHP 8.1 & MySQL 5.7 Custom Commands Failed

Rerolled for 10.1

English

CreditAttribution: catch at Third and Grove commented 17 February 2023 at 13:08

Status:	Needs review	» Needs work
Issue tags:		+Needs issue summary update

+++ b/core/lib/Drupal/Core/StreamWrapper/LocalStream.php
@@ -243,37 +243,34 @@ public function stream_cast($cast_as) {
 
       case STREAM_META_ACCESS:
         $return = chmod($target, $value);
+        if ($return) {
+          // For convenience clear the file status cache of the underlying file,
+          // since metadata operations are often followed by file status checks.
+          clearstatcache(TRUE, $target);
+          return TRUE;
+        }
         break;

The issue title and summary says remove the call, but this is moving it around - can we not remove it entirely?

Comment #29

17 February 2023 at 13:08

Version:

10.1.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.