User Embed

Please check git instructions ;)
It should be git clone --branch 7.x-1.x http://git.drupal.org/sandbox/drupaldrop/2469561.git user_embed

Some coding standard issues :) http://pareview.sh/pareview/httpgitdrupalorgsandboxdrupaldrop2469561git

Hello

Mannual review
1. README.txt is missing.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hey drupaldrop, I think these are not a project applications. Please check https://www.drupal.org/node/1975228 to add review bonus.

• As Manjit told, these are not project application reviews. You should reivew issues in https://www.drupal.org/project/issues/projectapplications?status=8. and then add the PAReview Tag
• Consider adding Module description to the module page

Automated Review

You still have some issues here. See http://pareview.sh/pareview/httpgitdrupalorgsandboxdrupaldrop2469561git

Manual Review

README.txt/README.md

You REAMME.txt needs more work. There is a typo for "refrencing" and a full stop after the "refrencing" is in the wrong place. Also please see https://www.drupal.org/node/2181737 for README.txt template suggestions.

Code long/complex enough for review

Your total line count is under the recommended minimum of 120 lines and your total function count is under the recommended minimum of 5 functions. See https://groups.drupal.org/node/195848

If you do some of the suggestions in the next section you should be able to get past this.

Coding style & Drupal API usage

You code does not work (at least for me).

(*) Your function _user_embed_config_form() is getting the variable user_embed_links for default and then saving it as embed_user_links. This causes nothing to work.

Once I corrected this locally I did manage to get the code to work however it took a few attempts. You have not explicitly documented an example of how the code should work. This should be in the README.txt file and your project page (See https://www.drupal.org/node/997024).

(+) Your .info this has an incorrect location to the configuration page, currently is "configure = admin/config/content/userembed" and should be "configure = /admin/config/content/user_embed"

I feel think the setting page could do with a small introduction to what I am about to enable as it is not clear.

I am unsure if you are able to to the same feature uses tokens module or token filter module, if not it might be nice to change the input from [chris] to [user:chris] (or something) that way it match up with notation people currently use and also reduce the likely hood of a user wanting to include [chris] as text inside the body.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.