Current formUpdated event is not great, it doesn't trigger when hitting delete/backspace in text fields, doesnt react to copy/paste.

  1. Make the event trigger for backspace, delete, copy/paste, input (when using chinese/japanese input methods)
  2. Make views, machine name use this event instead of their own.
CommentFileSizeAuthor
#18 core-js-improve-formUpdate-2456225-6.patch1.7 KBdrupaldrop
#5 core-js-improve-formUpdate-2456225-5.patch1.64 KBnod_
#2 core-js-improve-formUpdate-2456225-1.patch657 bytesnod_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Issue tags: +ie8

Looks like the input event is all we need. Tagging IE8 because it's not supported by it.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Active » Needs review
FileSize
core-js-improve-formUpdate-2456225-1.patch657 bytes
Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Category: Task » Bug report
Status: Needs review » Reviewed & tested by the community

It's a bug, not a task :).

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Tested using http://jsfiddle.net/6bSX6/ and can confirm the bug. But what happened to

Make views, machine name use this event instead of their own.

From the issue summary?

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs work » Needs review
FileSize
core-js-improve-formUpdate-2456225-5.patch1.64 KB

Here it is.

droplet’s picture

droplet CreditAttribution: droplet commented 
+++ b/core/misc/form.js
@@ -134,7 +134,7 @@
+          var events = 'change.formUpdated input.formUpdated ';

+++ b/core/misc/machine-name.js
@@ -133,9 +133,9 @@
+          $source.on('formUpdated.machineName', eventData, machineNameHandler)

required to add `formUpdated` event here.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs review » Needs work
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer commented

Um not sure what you mean here

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs work » Needs review

wired caches on my end. It wasn't load form.js after clean cache. But helping to find a bug #2490146: Prevent empty request on machine name transliterate.

Re-tested #5. It worked on Mac & Windows, I can't confirm it with Linux..
https://www.drupal.org/node/812354#comment-3072460

(Overall, it's better than now)

Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community

Looks great to me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: core-js-improve-formUpdate-2456225-5.patch, failed testing.

Status: Needs work » Needs review

Fabianx queued 5: core-js-improve-formUpdate-2456225-5.patch for re-testing.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community

RTBC, random test fail (go to failed in browser test base ...)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: core-js-improve-formUpdate-2456225-5.patch, failed testing.

Status: Needs work » Needs review

Fabianx queued 5: core-js-improve-formUpdate-2456225-5.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: core-js-improve-formUpdate-2456225-5.patch, failed testing.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commented
Issue tags: +Needs reroll
drupaldrop’s picture

drupaldrop CreditAttribution: drupaldrop commented
FileSize
core-js-improve-formUpdate-2456225-6.patch1.7 KB

patch is rerolled - there were no conflicts - Auto merge

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer commented
Status: Needs work » Needs review
drupaldrop’s picture

drupaldrop CreditAttribution: drupaldrop commented
Issue tags: -Needs reroll
Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Yay! This also improves things for In-Place Editing :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed a9f2eea and pushed to 8.0.x. Thanks!

  • alexpott committed a9f2eea on 8.0.x 
    Issue #2456225 by nod_, drupaldrop, droplet: Improve formUpdated event

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.