drush-psysh

  1. This is a module that integrates psysh into Drush so that a developer can use a full fledged REPL in a Drupal bootstrapped environment
  2. screenshot: screenshot
  3. git clone --branch 7.x-1.x http://git.drupal.org:sandbox/grota/2486135.git or git clone --branch 7.x-1.x https://github.com/grota/drush-psysh.git

Comments

grota’s picture

grota commented
Issue summary: View changes
t0xicCode’s picture

t0xicCode commented
Assigned: Unassigned » t0xicCode

I'll give it a review later today or tomorrow morning

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxgrota2486135git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

grota’s picture

grota commented
Status: Needs work » Needs review

Fixed the various coding standard issues, I left the @author tag though to give credit to Justin Hileman

t0xicCode’s picture

t0xicCode commented
Assigned: t0xicCode » Unassigned
Status: Needs review » Reviewed & tested by the community

This might fall under the Code too simple category, but it should at least pass the "one-time promotion" criteria.

Regarding the @author tag, Justin's contribution are logged by git itself, so I think removing the tag to match Drupal standards is fine.

Overall the module passes the review process IMO, so I'm marking it as RTBC.

grota’s picture

grota commented

ok, removed the @author tag (and update to the latest version of psysh in composer.json), it should be ok now.

grota’s picture

grota commented

any news on this? how can I move this issue ahead?

t0xicCode’s picture

t0xicCode commented

I think getting a PAReview Bonus might help expedite the resolution of this issue.

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.