With the next beta coming out, it'd be great to also do some code clean up per PAReview.sh!

  • Remove "version" from the ./modules/stock/commerce_reports_stock.info file, it will be added by drupal.org packaging automatically.
  • Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting
    ./commerce_reports.module:                                                                          PHP script, ASCII text, with very long lines, with CRLF line terminators
    commerce_reports.module
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...rupal/modules/maintainer/commerce_reports/tests/commerce_reports.test
    ---------------------------------------------------------------------------
    FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
    ---------------------------------------------------------------------------
      85 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     104 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     301 | WARNING | Unused variable $total.
     378 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     505 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     518 | WARNING | Unused variable $average.
     594 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
    ---------------------------------------------------------------------------
    
    
    FILE: ...intainer/commerce_reports/modules/tax/tests/commerce_reports_tax.test
    ---------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    ---------------------------------------------------------------------------
     54 | WARNING | Unused variable $tax_rate.
     82 | WARNING | Are you accessing field values here? Then you should use
        |         | LANGUAGE_NONE instead of 'und'
    ---------------------------------------------------------------------------
    
    
    FILE: ...s/maintainer/commerce_reports/modules/tax/commerce_reports_tax.module
    ---------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    ---------------------------------------------------------------------------
     162 | WARNING | There must be no blank line following an inline comment
     214 | WARNING | Do not use DELETE queries with db_query(), use
         |         | db_delete() instead
     297 | WARNING | Unused variable $write.
    ---------------------------------------------------------------------------
    
    
    FILE: ...modules/stock/includes/views/commerce_reports_stock.views_default.inc
    ---------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------
     119 | WARNING | Unused variable $translatables.
    ---------------------------------------------------------------------------
    
    
    FILE: ...intainer/commerce_reports/modules/stock/commerce_reports_stock.module
    ---------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------
     178 | WARNING | Unused variable $pid.
    ---------------------------------------------------------------------------
    
    
    FILE: ...ommerce_reports/modules/patterns/tests/commerce_reports_patterns.test
    ---------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------
     31 | WARNING | Unused variable $line_items.
    ---------------------------------------------------------------------------
    
    
    FILE: ...ommerce_reports/modules/geckoboard/commerce_reports_geckoboard.module
    ---------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    ---------------------------------------------------------------------------
     233 | WARNING | There must be no blank line following an inline comment
     241 | WARNING | There must be no blank line following an inline comment
    ---------------------------------------------------------------------------
    
    Time: 1.93 secs; Memory: 40Mb
    
  • Codespell has found some spelling errors in your code.
    ./commerce_reports.module:170: apperance  ==> appearance
    ./modules/tax/tests/commerce_reports_tax.test:114: apparant  ==> apparent
    ./modules/patterns/commerce_reports_patterns.admin.inc:14: occurence  ==> occurrence
    ./modules/patterns/commerce_reports_patterns.batch.inc:21: occurences  ==> occurrences
    ./modules/patterns/commerce_reports_patterns.batch.inc:21: occurences  ==> occurrences
    ./modules/patterns/commerce_reports_patterns.batch.inc:21: occurences  ==> occurrences
    ./modules/patterns/commerce_reports_patterns.batch.inc:119: occurences  ==> occurrences
    ./modules/patterns/commerce_reports_patterns.batch.inc:121: occurences  ==> occurrences
    

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

CommentFileSizeAuthor
#2 pareview.txt86.21 KBmglaman

Comments

mglaman’s picture

Body missing?

mglaman’s picture

Issue summary: View changes
StatusFileSize
new86.21 KB

Too much content in body apparently, attaching full dump.

mglaman’s picture

Status: Active » Postponed

Made some changes. Patterns & Geckboard have not been touched in 4.x and remain needing work. Postponing until then.

mglaman’s picture

mglaman’s picture