Problem/Motivation

When adding multiple fields or other elements in views at once, a progress indicator is shown in the modal. This progress indicator is styled as pager, which is not correct since a user cannot page trough the fields, instead the order is fixed.
The placement of the indicator is a little out of sight and separate from the title of the added objects.

Proposed resolution

The progress indicator needs to be styled as a progress indicator instead of a pager, so we need to alter the styling. the placement in HTML needs to be altered to the correct location. I attached some mock-up's as attachments.

Remaining tasks

  • agree on desired styling and placement
  • alter styling
  • alter php to generate progress indicator on the desired spot on the modal

User interface changes

Styling and placement of the progress indicator.

API changes

No API changes necessary.

CommentFileSizeAuthor
#15 2473877-10.patch2.05 KBquietone
#10 2473877-10.patch2.05 KBlendude
#10 Screenshot 2021-03-16 at 14.30.44.png27.38 KBlendude
progress indicator integrated with title.png122.87 KBpefferen
progress indicator before title.png147.76 KBpefferen
progress indicator after title.png146.31 KBpefferen
progress indicator after title with brackets.png146.34 KBpefferen

Comments

pefferen’s picture

pefferen commented
Issue tags: +drupaldevdays

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Active » Needs review
Issue tags: -views, -views ui
StatusFileSize
new Screenshot 2021-03-16 at 14.30.44.png27.38 KB
new 2473877-10.patch2.05 KB

Wow! These suggestions are SOOOO much better than the current look. Options 2-4 are probably easier, but I love the clarity of option 1, so let's see what breaks there.

After:

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

I agree, this looks a lot better, since this is a visual change I don't think this needs tests?

quietone’s picture

quietone commented
Version: 9.4.x-dev » 9.5.x-dev
StatusFileSize
new 2473877-10.patch2.05 KB

For whatever reason this is not retesting the patch every 2 days. Re-uploading the patch.

  • catch committed c9989db on 10.0.x 
    Issue #2473877 by Lendude, quietone, pefferen: Views UI progress...
  • catch committed 46e7443 on 10.1.x
    Issue #2473877 by Lendude, quietone, pefferen: Views UI progress...
  • catch committed 388393e on 9.5.x
    Issue #2473877 by Lendude, quietone, pefferen: Views UI progress...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Looks like a really good change.

Committed/pushed to 10.1.x and cherry-picked back through to 9.5.x, thanks!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Opened a followup: #3295709: .views-progress-indicator CSS is unused

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.