Problem/Motivation

Now that #2232861: Create BrowserTestBase for web-testing on top of Mink the path is clear to write a BrowserKit based driver that uses the kernel to simulate web requests - aka Look Ma no http.

Proposed resolution

Write a new BrowserKit based driver (we just need to sub-class and implement doRequest method).
Write a KernelWebTestBase class that uses said driver.
Write a sample test that uses KernelWebTestBase to test Request/Response without http.

Remaining tasks

Everything

User interface changes

None

API changes

New testing class

CommentFileSizeAuthor
#10 step_3_create_a-2469717-10.patch1.14 KBlarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

chx CreditAttribution: chx at Tag1 Consulting commented

This is an incredibly dangerous move -- look ma, we do not find the Drupal - web server interaction bugs any more (Wasn't there an issue within the last two weeks where Apache is fine with two HTTP Accept headers and appends them together while nginx will send only the second one. Opsie.). I wonder whether it'd be possible for the test runner to pick so that drupalci could run web servers rarely and the speedier no-http versions all the time.

grom358’s picture

grom358 CreditAttribution: grom358 commented

Is this still block by exit calls in core? Or have they all been removed now?

Also I don't think like with JavascriptTestBase we need a subclass for this. Should be able to have the no-http driver registered on the mink session. This avoids the problem @chx mentions. Could choose to use no-http as the default and switch to a http driver to detect HTTP interaction bugs.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

There is already such a driver out there, see \Symfony\Component\HttpKernel\Client

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

Is this issue a duplicate/obsolete?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

Well, IMHO this is something we could try out once we have all our tests converted over. It could conceptually bring quite a speed difference, but more important, it would ensure that we leak less things per request. On top of that, this issue is correctly prioritiesed as normal.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Version: 8.3.x-dev » 8.4.x-dev
Component: simpletest.module » phpunit
Related issues: +#2807237: PHPUnit initiative

Now #2829346: Allow repeated calls to DrupalKernel::setSitePath() is in, this is now unblocked again I think.

Played around with it for an hour or so tonight, but not much joy.

Basically, our drupalUserIsLoggedIn method isn't finding the session in the session storage, despite the login working (as seen in the html output). So something about mixing the two kernels.

Not worth putting a patch up.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
FileSize
step_3_create_a-2469717-10.patch1.14 KB

In case someone else wants to poke about

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

Are you sure that at least the simpletest cookie workes? This is the steps I always struggled with.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

The html output shows the logged in user, but yeah could be the cookie, didn't think of that

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

Note: #1497162: Eliminate the use of exit in core might still be a problem here.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.