[D7] Commerce My Delivery Times

I runned your code through "pareview.sh" there are errors to fix before a manual review.. please fix those errors first.

You can see the list for your module here:
http://pareview.sh/pareview/httpgitdrupalorgsandboxpratikmehta192466947git

I don;t know why the link to the error list I gave you before is not working. Try this:
http://pareview.sh/pareview/httpgitdrupalorgsandboxpratikmehta192466947git

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Git Clone URL not working
Change it as git clone --branch 7.x-1.x http://git.drupal.org/sandbox/pratik.mehta19/2466947.git commerce_my_delivery_times

Let's keep this closed until we get a response from @pratik.mehta19.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Pratik,

I didn't completely know the purpose of your module yet. But When I installed it and used the form elements, I could detect some serious Security vulnerabilities.

Here is the list of my suggestions:

1. Security Issue first :) In the page admin/commerce/delivery-times/holiday-configuration , try inserting the Holiday reason as:

<script>alert('xss');</script>

Did you get a alert box when seeing the list again, this is because you have not sanitized the text before outputting them. Please read through Handle text in a secure fashion. Use check_plain while building the $row in holiday_calendar_form function.

2. What is this function used for my_delivery_times_checkout_form. Is this implementation of hook_form(), then the function name should start with commerce_my_delivery_times. Read through the function of hook_form before using it. Also In the function build the table manually using HTML tags, You should not bring the theming part inside a module. Use theme function to build the table.

3. Take care of the pareview there are many.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,
I've installed this module and setup elements in page Delivery Time Slots Configuration
but in page chekout this appear this error
Warning: max(): Array must contain at least one element in my_delivery_times_checkout_form() (linea 83 di C:\htdocs\devcibario\sites\all\modules\commerce_my_delivery_times\includes\my_delivery_times.checkout_pane.inc).

have you any idea? what's i missed setup?

Thank's

Automated Review

[Best practice issues identified by pareview.sh / drupalcs / coder. Please don't copy/paste all of the results unless they are short. If there are a lot, then post a link to the automated review and mention that problems should be addressed.]

You have some automated review issues identified here: http://pareview.sh/pareview/httpgitdrupalorgsandboxpratikmehta192555313git

FILE: ...www/drupal-7-pareview/pareview_temp/commerce_my_delivery_times.module
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
---------------------------------------------------------------------------
79 | WARNING | Open page callback found, please add a comment before the
| | line why there is no access restriction
128 | WARNING | #description values usually have to run through t() for
| | translation
131 | WARNING | All variables defined by your module must be prefixed

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

No: List of security issues identified.]

1. In commerce_my_delivery_times_menu(), set-delivery-time-slot always returns true. I would suggest attaching this to a permission.

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. It is recommended to used #attached for adding javascript and CSS within projects instead of drupal_add_js and drupal_add_css
2. Any text that is output to the page should be wrapped in a t() function. You've done that in a couple of places but there is some text in commerce_my_delivery_times_configuration_update() which doesn't seem like it can be translated and in commerce_my_delivery_times_review_checkout_form()
3. It is not recommended to use $_REQUEST as access to this can be blocked within PHP
4. I would recommend instead of hard coding date formats you use format_date to get one of the formats defined within the CMS.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.