As a follow-up to #2462589: Provide test coverage for access checking of all views fields.... That issue created generic tests to validate that base entity fields obeyed entity access rules when used in views.

However, when that patch was created, not all of the base entity fields were included, because they would have at that time failed the tests.

So, once all of the critical "convert this field to use an Entity-aware formatter in Views" issues on #2393339: [META] Make sure Views base fields are using Field API for formatting, and do not lose functionality are fixed, we need to come back here and make sure all the entity base fields for all our entities are covered.

Novice task

Start with the patch in comment #8. See comment #12 for instructions.

CommentFileSizeAuthor
#53 interdiff_49-53.txt5.7 KBnamitasaxena
#53 2464635-53.patch12.52 KBnamitasaxena
#49 2464635-49.patch12.51 KBvsujeetkumar
#46 2464635-46.patch11.76 KBkostyashupenko
#45 2464635-45.patch11.8 KBvacho
#39 interdiff-31-39.txt3.3 KBpritish.kumar
#39 2464635-39.patch11.76 KBpritish.kumar
#31 2464635-31.patch11.97 KBmohit_aghera
#26 2464635-hack-assertFieldAccess.txt558 byteslokapujya
#25 2464635-25.patch11.78 KBlokapujya
#25 2464635-25-interdiff.txt1.25 KBlokapujya
#21 2464635-21-interdiff.txt3.69 KBlokapujya
#21 2464635-21.patch11.73 KBlokapujya
#17 2464635-second-17.patch12.25 KBvg3095
#17 interdiff-2464635-8-17.txt9.61 KBvg3095
#13 Added-some-more-tests-in-AggregatorFeedViewsFieldAccessTest-2464635-13.patch6.21 KBvg3095
#8 2464635-first-pass.patch8.71 KBjhodgdon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

I don't think this issue has to be critical, given that we have a good amount of test coverage with that other patch AND
all things do rely on the same underlying code, so I would vote just for major.

jhodgdon’s picture

I was thinking that this would be the place to say "Make sure we really got everything". But either way, the parent is critical after all.

xjm’s picture

Shouldn't we just be adding to the test in each issue? That's the testing gate.

I don't think this is critical on its own but also I don't think it's a separate issue.

xjm’s picture

Priority: Critical » Major
jhodgdon’s picture

Once we get #2462589: Provide test coverage for access checking of all views fields. in, yes we can add tests in each issue. Just depends on the order of things, and whether that actually happens. If everything gets added as we go then we can eventually just close this.

xjm’s picture

Ah, I get it now. Thanks!

Mile23’s picture

Issue tags: +@todo clean-up

Mentioned in @todos in a number of test files.

jhodgdon’s picture

Status: Active » Needs review
FileSize
8.71 KB

Here's a first pass patch. I grepped for this issue number in Core, and checked to see which base fields on each entity were and were not covered by access tests. I un-commented a few lines that were already there, added a few lines if they were obvious, and made a list of additional base fields that still need tests added.

So... it's not done but at least it shows more clearly what needs to be done, and we can also see if the uncommented and new tests pass.

Status: Needs review » Needs work

The last submitted patch, 8: 2464635-first-pass.patch, failed testing.

jhodgdon’s picture

Well, it looks like the Comment one was wrong, as there's no langcode() method on Comment:

Fatal error: Call to undefined method Drupal\comment\Entity\Comment::langcode() in /var/www/html/core/modules/comment/src/Tests/Views/CommentViewsFieldAccessTest.php on line 71

Also the tests failed on the added comment_type test in Comment, and also one of the timestamp fields in File (either file changed or file created -- not sure which of the two newly uncommented lines failed).

So this still needs some work, as well as some more tests added, but it should probably be done?

tstoeckler’s picture

@jhodgdon: Looking at some of the other tests it seems you want $comment->language()->getName() ?

jhodgdon’s picture

Issue summary: View changes
Issue tags: +Novice

Yes probably. The other test fails need to still be looked into, though, plus more tests need to be added. I don't really plan to work on this... maybe we should mark it Novice, as it's not really all that difficult to make sure those fields are set on the entities in the test, and add tests for them. Hopefully one of our outstanding Novice code contributors will pick it up.

Instructions for what needs to be done still:

a) Start with the patch in comment #8.

b) Background information: these tests go something like this. First, they create an entity of the type being tested, using code something like this ("user" entity in this example):

    $user = User::create([
      'name' => 'test user',
      'mail' => 'druplicon@drop.org',
... [set other fields up]
    ]);
    $user->save();

Then, they test access for each of the base fields on the entity, using code something like this:

    $this->assertFieldAccess('user', 'name', 'test user');
    $this->assertFieldAccess('user', 'mail', 'druplicon@drop.org');
... [test other fields]

So basically, you need to both make sure that the created entity has a value set, and then test its access by calling assertFieldAccess, passing in the value that you set on the entity.

c) You'll need to fix the 4 test failures, which are detailed in comment #10. Comment #11 has a suggestion for how to fix the PHP error. For the others, see (b).

d) In the patch in #8, there are still some @todo lines remaining that say we need to test additional fields. For each of these, add them to the test [see (b)] and then remove the @todo comments.

vg3095’s picture

I added some more tests in AggregatorFeedViewsFieldAccessTest .
I am new at this, so point me , if I am going in the wrong direction

dimaro’s picture

Status: Needs work » Needs review

Update to run the test.

Status: Needs review » Needs work
jhodgdon’s picture

Please, when you make a patch on an issue that had a previous patch, always make an interdiff file. Without one, it is very difficult to see what you have changed. At least you noted in your comment what you had done, so that is helpful -- but next time, please do make an interdiff file.

Anyway, it looks like the Aggregator additions are heading in the right direction, thanks!

I did notice one typo: in the tests, you tested 'image' twice -- the second time I think it should have been 'modified'.

Also I thought some of the values that were submitted for the test field were a bit weird. For instance,

+      'modified' => 'Get description of feed',

I think that 'modified' is supposed to be a time stamp? So please look over all of the values in that section, and make sure each one is something that is actually reasonable for that value to be. And I don't think I would use 0 for timestamps, even though that is a legal value.

Thanks!

vg3095’s picture

Thank you for the detailed feedback,
Now I have made an interdiff file and added some more tests.

vg3095’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 17: 2464635-second-17.patch, failed testing.

jhodgdon’s picture

This is looking better, but there are still some problems, and also there's quite a bit of work to be done in this patch. And... I'm not sure if everything in the interdiff file actually got into the patch? I reviewed the patch file, not the interdiff...

Some notes:

  1. +++ b/core/modules/aggregator/src/Tests/Views/AggregatorFeedViewsFieldAccessTest.php
    @@ -35,18 +35,38 @@ protected function setUp($import_test_views = TRUE) {
    -    $feed = Feed::create([
    +     $feed = Feed::create([
    

    This change is incorrect. The indentation of this line was correct in the original. Why did you change this line?

  2. +++ b/core/modules/aggregator/src/Tests/Views/AggregatorFeedViewsFieldAccessTest.php
    @@ -35,18 +35,38 @@ protected function setUp($import_test_views = TRUE) {
    +      'image' => 'Get description of feed',
    

    See previous review. This is not a good value for 'image'.

  3. +++ b/core/modules/aggregator/src/Tests/Views/AggregatorFeedViewsFieldAccessTest.php
    @@ -35,18 +35,38 @@ protected function setUp($import_test_views = TRUE) {
    +      'hash' => 'Get hash',
    +      'etag' => 'Get entity tag',
    

    I'm not sure about these two either -- are those really values you'd expect for a feed hash and etag? It would be better to use realistic values. See previous review.

  4. +++ b/core/modules/comment/src/Tests/Views/CommentViewsFieldAccessTest.php
    @@ -59,13 +64,16 @@ public function testCommentFields() {
    -    ]);
    +         ]);
    

    This indentation change is also incorrect.

  5. +++ b/core/modules/comment/src/Tests/Views/CommentViewsFieldAccessTest.php
    @@ -59,13 +64,16 @@ public function testCommentFields() {
    +    // Still needs coverage for: pid,entity_id
    

    If you are going to comment out the line for comment_type (a few lines down), you need to add it to this "Still needs coverage" line.

  6. +++ b/core/modules/views/src/Tests/Handler/EntityTestViewsFieldAccessTest.php
    @@ -32,14 +32,15 @@ protected function setUp($import_test_views = TRUE) {
    -    ]);
    +      ]);
    

    This indentation change is incorrect.

  7. +++ b/core/modules/views/src/Tests/Handler/EntityTestViewsFieldAccessTest.php
    @@ -32,14 +32,15 @@ protected function setUp($import_test_views = TRUE) {
    +    }
    

    The indentation of this } is incorrect. The original was correct.

lokapujya’s picture

Status: Needs work » Needs review
FileSize
11.73 KB
3.69 KB

The reason that comment_type fails is that the view created by assertFieldAccess() does not show the comment type id.

If I were to create a view in the UI - By default, the view would show the comment type label. The test might not have even created a comment type (and have no label to show). So would assertFieldAccess() need to be modified to show the comment type id?

lokapujya’s picture

Also, do we really need these tests? access tests on every base field? Why would one be different from any other?

jhodgdon’s picture

Title: Follow-up: Enable additional tests for base entity field access checking » Follow-up: Enable additional tests for base entity field access checking in Views

The code that made all base fields both translatable and under access control was added piecemeal (by type of field), and testing of each piece (and whether or not all needed pieces were actually done) was deferred to this issue. Right now they are not tested.

Status: Needs review » Needs work

The last submitted patch, 21: 2464635-21.patch, failed testing.

lokapujya’s picture

I broke some tests, so fixing those first.

lokapujya’s picture

Regarding comment_type, the attached interdiff doesn't fix it. :( I attempted to force the view to show the id; It might be trying to display the comment type label, which doesn't exist.

Status: Needs review » Needs work

The last submitted patch, 25: 2464635-25.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

The last submitted patch, 25: 2464635-25.patch, failed testing.

dimaro’s picture

Issue tags: +Needs reroll

Tagging as "Needs reroll" against 8.1.x

mohit_aghera’s picture

Re-rolling against 8.1.x

Status: Needs review » Needs work

The last submitted patch, 31: 2464635-31.patch, failed testing.

dimaro’s picture

Issue tags: -Needs reroll

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Torenware’s picture

Issue tags: +Baltimore2017

This one needs a patch reroll, not too bad as a novice task.

benjifisher’s picture

Issue tags: -Baltimore2017 +Needs reroll
Mile23’s picture

Issue tags: -Needs reroll

Patch in #31 still applies to 8.3.x.

  1. +++ b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorFeedViewsFieldAccessTest.php
    @@ -34,14 +34,33 @@ public function testAggregatorFeedFields() {
    +    // Still needs coverage for: fid,link
    
    +++ b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorItemViewsFieldAccessTest.php
    @@ -46,7 +46,7 @@ public function testAggregatorItemFields() {
    +    // Still needs coverage for: iid, fid, link, author, timestamp, guid.
    
    +++ b/core/modules/comment/tests/src/Kernel/Views/CommentViewsFieldAccessTest.php
    @@ -58,9 +63,12 @@ public function testCommentFields() {
    +    // Still needs coverage for: pid,entity_id
    
    +++ b/core/modules/node/tests/src/Kernel/Views/NodeViewsFieldAccessTest.php
    @@ -48,12 +48,15 @@ public function testNodeFields() {
    +    // Still needs coverage for: revision_timestamp, revision_uid, revision_log,
    +    // revision_translation_affected.
    
    +++ b/core/modules/user/tests/src/Kernel/Views/UserViewsFieldAccessTest.php
    @@ -45,11 +45,17 @@ public function testUserFields() {
    +    // Still needs coverage for:roles.
    
    +++ b/core/modules/views/tests/src/Kernel/Handler/EntityTestViewsFieldAccessTest.php
    @@ -31,10 +31,11 @@ public function testEntityTestFields() {
    +    // Still needs tests for: type, created, user_id.
    

    Either add these tests or make a follow-up to add them if there's some reason we can't add them now.

  2. +++ b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorItemViewsFieldAccessTest.php
    @@ -46,7 +46,7 @@ public function testAggregatorItemFields() {
         // @todo Expand the test coverage in https://www.drupal.org/node/2464635
    
    +++ b/core/modules/comment/tests/src/Kernel/Views/CommentViewsFieldAccessTest.php
    @@ -58,9 +63,12 @@ public function testCommentFields() {
         // @todo Expand the test coverage in https://www.drupal.org/node/2464635
    
    +++ b/core/modules/node/tests/src/Kernel/Views/NodeViewsFieldAccessTest.php
    @@ -48,12 +48,15 @@ public function testNodeFields() {
         // @todo Expand the test coverage in https://www.drupal.org/node/2464635
    
    +++ b/core/modules/user/tests/src/Kernel/Views/UserViewsFieldAccessTest.php
    @@ -45,11 +45,17 @@ public function testUserFields() {
         // @todo Expand the test coverage in https://www.drupal.org/node/2464635
    
    +++ b/core/modules/views/tests/src/Kernel/Handler/EntityTestViewsFieldAccessTest.php
    @@ -31,10 +31,11 @@ public function testEntityTestFields() {
         // @todo Expand the test coverage in https://www.drupal.org/node/2464635
    

    Remove all the @todos for this issue. Search the whole codebase and make sure there aren't others to address.

  3. +++ b/core/modules/comment/tests/src/Kernel/Views/CommentViewsFieldAccessTest.php
    @@ -5,6 +5,7 @@
    +use \Drupal\Core\Entity;
    

    Unused use statement.

  4. +++ b/core/modules/comment/tests/src/Kernel/Views/CommentViewsFieldAccessTest.php
    @@ -68,9 +76,15 @@ public function testCommentFields() {
    +    //$this->assertFieldAccess('comment', 'hostname', $comment->getHostname());
    ...
    +    //$this->assertFieldAccess('comment', 'entity_id', $comment->getCommentedEntityId());
    
    +++ b/core/modules/node/tests/src/Kernel/Views/NodeViewsFieldAccessTest.php
    @@ -48,12 +48,15 @@ public function testNodeFields() {
    +      //'revision_timestamp' => 1457760993,
    
    @@ -67,8 +70,10 @@ public function testNodeFields() {
    +    //$this->assertFieldAccess('node', 'revision_timestamp', $node->getRevisionCreationTime());
    +    //$this->assertFieldAccess('node', 'revision_translation_affected', $node->isRevisionTranslationAffected());
    

    Either fix or remove commented code.

Also a bunch of coding standards errors. Check the testbot results for a CS report: https://www.drupal.org/pift-ci-job/634797

pritish.kumar’s picture

Status: Needs work » Needs review
FileSize
11.76 KB
3.3 KB

As per the #38

Made the following changes.
1. Removed all the @todos for this issue
2. Removed Unused use statement.

Status: Needs review » Needs work

The last submitted patch, 39: 2464635-39.patch, failed testing.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

vacho’s picture

Issue tags: +Needs reroll
vacho’s picture

Patch rerolled.

kostyashupenko’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
11.76 KB

reroll of #39

Status: Needs review » Needs work

The last submitted patch, 46: 2464635-46.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

vsujeetkumar’s picture

Re-roll in 8.8.x and fixed some tests, Please review.

vsujeetkumar’s picture

Status: Needs work » Needs review

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

mradcliffe’s picture

Version: 8.9.x-dev » 9.2.x-dev
Status: Needs review » Needs work
Issue tags: +Europe2020

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because I think that good progress has been made in the past and it is still clear what needs to be done.

I bumped this to 9.2.x-dev and changed it back to Needs work based on my review of #49 below.

  1. +++ b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorFeedViewsFieldAccessTest.php
    @@ -34,14 +34,33 @@ public function testAggregatorFeedFields() {
    +    // Still needs coverage for: fid,link
    
    +++ b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorItemViewsFieldAccessTest.php
    @@ -45,8 +45,7 @@ public function testAggregatorItemFields() {
    +    // Still needs coverage for: iid, fid, link, author, timestamp, guid.
    
    +++ b/core/modules/comment/tests/src/Kernel/Views/CommentViewsFieldAccessTest.php
    @@ -67,9 +80,12 @@ public function testCommentFields() {
    +    // Still needs coverage for: pid,entity_id
    
    +++ b/core/modules/node/tests/src/Kernel/Views/NodeViewsFieldAccessTest.php
    @@ -48,12 +48,14 @@ public function testNodeFields() {
    +    // Still needs coverage for: revision_timestamp, revision_uid, revision_log,
    +    // revision_translation_affected.
    
    @@ -67,8 +69,10 @@ public function testNodeFields() {
    +    //$this->assertFieldAccess('node', 'revision_timestamp', $node->getRevisionCreationTime());
    +    //$this->assertFieldAccess('node', 'revision_translation_affected', $node->isRevisionTranslationAffected());
    
    +++ b/core/modules/user/tests/src/Kernel/Views/UserViewsFieldAccessTest.php
    @@ -45,11 +45,16 @@ public function testUserFields() {
    -    // @todo Expand the test coverage in https://www.drupal.org/node/2464635
    +    // Still needs coverage for:roles.
    
    +++ b/core/modules/views/tests/src/Kernel/Handler/EntityTestViewsFieldAccessTest.php
    @@ -31,11 +31,11 @@ public function testEntityTestFields() {
    -    // @todo Expand the test coverage in https://www.drupal.org/node/2464635
    -
    +    // Still needs tests for: type, created, user_id.
    ...
    +    $this->assertFieldAccess('entity_test', 'uuid', $entity_test->uuid());
    

    It looks like these tests still need to be written. I think this is the issue to do this, so I'm going to bump this back to Needs work to add the missing tests.

  2. +++ b/core/modules/user/tests/src/Kernel/Views/UserViewsFieldAccessTest.php
    @@ -57,11 +62,16 @@ public function testUserFields() {
    +    if($user->checkExistingPassword==TRUE)
    +     $this->assertFieldAccess('user', 'pass', $user->getPassword());
    

    1. Control statement should have a space between the statement and opening parantheses.

    2. Operator should have spaces on either side.

    3. Control statements should always be within code blocks (curly braces).

namitasaxena’s picture

Status: Needs work » Needs review
FileSize
12.52 KB
5.7 KB

Resolved 2nd point mentioned in #52 and coding standards. Working on remaining test cases.

lokapujya’s picture

  1. +++ b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorFeedViewsFieldAccessTest.php
    @@ -34,14 +34,32 @@ public function testAggregatorFeedFields() {
           'link' => 'https://www.drupal.org/rss.xml',
    

    I see link in the test data.

  2. +++ b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorFeedViewsFieldAccessTest.php
    @@ -34,14 +34,32 @@ public function testAggregatorFeedFields() {
    +    // Still needs coverage for: fid,link
    

    Comment says we need to add link.

  3. +++ b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorFeedViewsFieldAccessTest.php
    @@ -34,14 +34,32 @@ public function testAggregatorFeedFields() {
         $this->assertFieldAccess('aggregator_feed', 'url', $feed->getUrl());
    

    Here is the assert for url. I wonder if link needs a similar assert.

lokapujya’s picture

The FeedInterface doesn't have a getLink(), but it extends ContentEntityInterface, which extends FieldableEntityInterface, which extends EntityInterface, which has a toLink() function. Maybe, that's the function to call in the test.

lokapujya’s picture

Status: Needs review » Needs work

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

andypost’s picture

  1. +++ b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorItemViewsFieldAccessTest.php
    @@ -45,8 +45,7 @@ public function testAggregatorItemFields() {
    -    // @todo Expand the test coverage in https://www.drupal.org/node/2464635
    ...
    +    // Still needs coverage for: iid, fid, link, author, timestamp, guid.
    

    Should be added

  2. +++ b/core/modules/comment/tests/src/Kernel/Views/CommentViewsFieldAccessTest.php
    @@ -67,9 +79,11 @@ public function testCommentFields() {
         // @todo Expand the test coverage in https://www.drupal.org/node/2464635
    -
    +    // Still needs coverage for: pid,entity_id
    

    too

  3. +++ b/core/modules/file/tests/src/Kernel/Views/FileViewsFieldAccessTest.php
    @@ -52,8 +52,6 @@ public function testFileFields() {
    -    // @todo Expand the test coverage in https://www.drupal.org/node/2464635
    

    The test group also needs fix to "file" module