diff -u b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorFeedViewsFieldAccessTest.php b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorFeedViewsFieldAccessTest.php --- b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorFeedViewsFieldAccessTest.php +++ b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorFeedViewsFieldAccessTest.php @@ -48,7 +48,6 @@ // @todo Expand the test coverage in https://www.drupal.org/node/2464635 // Still needs coverage for: fid,link - $this->assertFieldAccess('aggregator_feed', 'title', $feed->label()); $this->assertFieldAccess('aggregator_feed', 'langcode', $feed->language()->getName()); $this->assertFieldAccess('aggregator_feed', 'url', $feed->getUrl()); diff -u b/core/modules/comment/tests/src/Kernel/Views/CommentViewsFieldAccessTest.php b/core/modules/comment/tests/src/Kernel/Views/CommentViewsFieldAccessTest.php --- b/core/modules/comment/tests/src/Kernel/Views/CommentViewsFieldAccessTest.php +++ b/core/modules/comment/tests/src/Kernel/Views/CommentViewsFieldAccessTest.php @@ -7,7 +7,6 @@ use Drupal\entity_test\Entity\EntityTest; use Drupal\user\Entity\User; use Drupal\Tests\views\Kernel\Handler\FieldFieldAccessTestBase; -use \Drupal\Core\Entity; /** * Tests base field access in Views for the comment entity. @@ -81,7 +80,6 @@ // @todo Expand the test coverage in https://www.drupal.org/node/2464635 // Still needs coverage for: pid,entity_id - $this->assertFieldAccess('comment', 'cid', $comment->id()); $this->assertFieldAccess('comment', 'cid', $comment_anonymous->id()); $this->assertFieldAccess('comment', 'comment_type', $comment->getTypeId()); @@ -96,10 +94,10 @@ $this->assertFieldAccess('comment', 'created', \Drupal::service('date.formatter')->format(123456)); $this->assertFieldAccess('comment', 'changed', \Drupal::service('date.formatter')->format(REQUEST_TIME)); $this->assertFieldAccess('comment', 'status', 'On'); - //$this->assertFieldAccess('comment', 'hostname', $comment->getHostname()); - //$this->assertFieldAccess('comment', 'thread', $comment->getThread()); + // $this->assertFieldAccess('comment', 'hostname', $comment->getHostname()); + // $this->assertFieldAccess('comment', 'thread', $comment->getThread()); $this->assertFieldAccess('comment', 'entity_type', $comment->getCommentedEntityTypeId()); - //$this->assertFieldAccess('comment', 'entity_id', $comment->getCommentedEntityId()); + // $this->assertFieldAccess('comment', 'entity_id', $comment->getCommentedEntityId()); $this->assertFieldAccess('comment', 'field_name', $comment->getFieldName()); } diff -u b/core/modules/node/tests/src/Kernel/Views/NodeViewsFieldAccessTest.php b/core/modules/node/tests/src/Kernel/Views/NodeViewsFieldAccessTest.php --- b/core/modules/node/tests/src/Kernel/Views/NodeViewsFieldAccessTest.php +++ b/core/modules/node/tests/src/Kernel/Views/NodeViewsFieldAccessTest.php @@ -48,8 +48,7 @@ 'promote' => 1, 'sticky' => 0, 'created' => 123456, - //'revision_timestamp' => 1457760993, - + // 'revision_timestamp' => 1457760993, ]); $node->save(); @@ -71,8 +70,8 @@ $this->assertFieldAccess('node', 'created', \Drupal::service('date.formatter')->format(123456)); $this->assertFieldAccess('node', 'changed', \Drupal::service('date.formatter')->format(REQUEST_TIME)); - //$this->assertFieldAccess('node', 'revision_timestamp', $node->getRevisionCreationTime()); - //$this->assertFieldAccess('node', 'revision_translation_affected', $node->isRevisionTranslationAffected()); + // $this->assertFieldAccess('node', 'revision_timestamp', $node->getRevisionCreationTime()); + // $this->assertFieldAccess('node', 'revision_translation_affected', $node->isRevisionTranslationAffected()); } } diff -u b/core/modules/user/tests/src/Kernel/Views/UserViewsFieldAccessTest.php b/core/modules/user/tests/src/Kernel/Views/UserViewsFieldAccessTest.php --- b/core/modules/user/tests/src/Kernel/Views/UserViewsFieldAccessTest.php +++ b/core/modules/user/tests/src/Kernel/Views/UserViewsFieldAccessTest.php @@ -46,8 +46,10 @@ 'timezone' => 'ut1', 'created' => 123456, 'pass' => 'pass', - 'access' => 0, //A value of 0 means the user has never accessed the site - 'login' => 0, //Last login time + // A value of 0 means the user has never accessed the site. + 'access' => 0, + // Last login time. + 'login' => 0, 'init' => 'entity_test', ]); @@ -55,7 +57,6 @@ $user->save(); // Still needs coverage for:roles. - $this->assertFieldAccess('user', 'uid', $user->id()); $this->assertFieldAccess('user', 'uuid', $user->uuid()); $this->assertFieldAccess('user', 'langcode', $user->language()->getName()); @@ -67,11 +68,12 @@ $this->assertFieldAccess('user', 'status', 'On'); $this->assertFieldAccess('user', 'created', \Drupal::service('date.formatter')->format(123456)); $this->assertFieldAccess('user', 'changed', \Drupal::service('date.formatter')->format(REQUEST_TIME)); - if($user->checkExistingPassword==TRUE) - $this->assertFieldAccess('user', 'pass', $user->getPassword()); - $this->assertFieldAccess('user', 'access', $user->getLastAccessedTime()); - $this->assertFieldAccess('user', 'login', $user->getLastLoginTime()); - $this->assertFieldAccess('user', 'init', $user->getInitialEmail()); + if ($user->checkExistingPassword == TRUE) { + $this->assertFieldAccess('user', 'pass', $user->getPassword()); + } + $this->assertFieldAccess('user', 'access', $user->getLastAccessedTime()); + $this->assertFieldAccess('user', 'login', $user->getLastLoginTime()); + $this->assertFieldAccess('user', 'init', $user->getInitialEmail()); } }