Follow-up to #1944572: Remove "ul.menu" dependency to prevent theme clashes

The current naming schema of book_tree is not like the plan in #1944572: Remove "ul.menu" dependency to prevent theme clashes and therefore need to be changed.

CommentFileSizeAuthor
#1 Issue-2461691-bookmenu-template-suggestion-should-be.patch2.88 KBhass
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch Issue-2461691-bookmenu-template-suggestion-should-be.patch. Unable to apply patch. See the log in the details link for more information. View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

hass’s picture

FileSize
2.88 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch Issue-2461691-bookmenu-template-suggestion-should-be.patch. Unable to apply patch. See the log in the details link for more information. View
Cottser’s picture

I'm not sure I understand this, book-tree is a separate template, not a theme suggestion. This just makes things confusing IMO. What's the bug?

hass’s picture

It does not use the same naming scheme you suggested in the other case. With this patch follows same naming.

This issue also goes back to the inflexible menu theming. This tree is a menu...

Cottser’s picture

Status: Needs review » Needs work

The last submitted patch, 1: Issue-2461691-bookmenu-template-suggestion-should-be.patch, failed testing.

hass’s picture

This is still implementing the wrong theme suggestions... See the topic, please.

hass’s picture

Title: "book_menu" template suggestion should be "menu__book__" » "book_tree" template suggestion should be "menu__book__"
Cottser’s picture

@hass that's why @joelpittet re-tested rather than closing the issue. This issue can still be worked on but the patch needs to be updated now that #2443361: Remove theme_book_link, make book tree align with MenuLinkTree build has been committed.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

This would be nice if it could extend from the menu.html.twig, may be tricky to do this in a BC way, but could be possible if the markup stays the same and the suggestions are providing both.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.