A payment module for Drupal Commerce, providing the following payment methods:

- Australian Post SecurePay Direct Post
- NAB (National Australia Bank) Direct Post v2
As the two methods are almost identical, this module provides a working, tested method for both.

It's hard to test a real payment method if you don't have test account for the particular gateway. Thankfully this module provides a test mode called 'Local Test' which uses a local endpoint (provided by a sub-module which can be enabled separately).

Project page:
https://www.drupal.org/sandbox/roland.molnar/2422731

Git clone

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/roland.molnar/2422731.git commerce_securepay_au_direct_post_method
cd commerce_securepay_au_direct_post_method

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxrolandmolnar2422731git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

roland.molnar’s picture

roland.molnar commented

I have fixed the code errors and warnings, all clear now.

Submitted by Anonymous (not verified) on Thu, 02/26/2015 - 16:12
Review of the 7.x-1.x branch (commit 94c7c13):

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
Source: http://pareview.sh/ - PAReview.sh online service

roland.molnar’s picture

roland.molnar commented
Status: Needs work » Needs review
flaviovs’s picture

flaviovs commented

Automated Review

PASS

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication

No: Causes module duplication and/or fragmentation.

In #2428667: Direct Post method the author proposed a patch to implement this very same feature in the Commerce SecurePay(.com.au) module, and this is a cause of concern to me. The author should clarify his intents and, to avoid future rework and duplication, either close the mentioned issue (perhaps with a note pointing to this module page) and proceed with the module review, or withdraw this module and strive to make the patch into the other module.

Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements
Coding style & Drupal API usage
PASS

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

roland.molnar’s picture

roland.molnar commented

Thank you flaviovs for the review.
I have discussed this with the module's maintainer but forgotten to update the issue. We agreed that this should be a separate module, not a submodule.
Done now: https://www.drupal.org/node/2428667#comment-9784793
Roland

azeiteiro’s picture

azeiteiro commented

Automated Review

OK

Manual Review

Individual user account
Yes: Follows guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation, author confirms that: https://www.drupal.org/node/2428667#comment-9784793.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements
Coding style & Drupal API usage
(*) If you use variables, you have to erase them on uninstall. You may follow this: https://www.drupal.org/node/2274697
roland.molnar’s picture

roland.molnar commented

Hi @azeiteiro,

Thank you for the review.

This module does not introduce any variable so nothing to erase on uninstall.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented

@roland.molnar, Just a basic review.. please fix this https://pareview.sh/node/1095

warped’s picture

warped commented
Status: Needs review » Postponed (maintainer needs more info)

Thank you for your contribution!

After 2017 March 7 everyone can promote a project to a full project.  A full project has a short project name and a drupal.org/project URL.  It can also have releases (like alpha1 or 1.0).  Edit your sandbox project, and then choose the 'Promote' tab.

https://www.drupal.org/docs/8/understanding-drupal-version-numbers/drupa...
https://www.drupal.org/docs/8/choosing-a-drupal-version/what-do-version-...
https://www.drupal.org/docs/8/understanding-drupal-version-numbers/what-...
https://www.drupal.org/docs/8/choosing-a-drupal-version/release-stable-v...

If you'd like to opt into security coverage, please ensure your module is ready for a full release, and then set this issue back to 'needs review'

Immense apologies for how long it took to get to this review completed.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

I am closing this application for the lack for replies. I take the OP just needed to be able to promote the project.