Problem/Motivation

BlockLanguageTest calls $this->drupalGet('node') without installing the node module etc.

Proposed resolution

Make BlockLanguageTest by ensuring that it calls existing pages.

Remaining tasks

User interface changes

API changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because the test coverage is wrong.
Issue priority Normal because the issue was only found in a single test.
Unfrozen changes Unfrozen because it only changes tests. (Which? Specify.)
CommentFileSizeAuthor
#23 2430133-21.patch3.63 KBquietone
#21 2430133-21.patch3.63 KBjeroent
#20 interdiff-2430133-18-20.txt3.54 KBjeroent
#20 2430133-20.patch3.65 KBjeroent
#18 2430133-18.patch2.03 KBjeroent
#6 blocklanguagetest_tests-2430133-4.patch2.24 KBmgifford
#4 blocklanguagetest_tests-2430133-4.patch2.24 KBAnonymous (not verified)
#1 2430133-demo-broken-block-language-test.patch2.81 KBznerol

Comments

znerol’s picture

znerol commented
Issue summary: View changes
StatusFileSize
new 2430133-demo-broken-block-language-test.patch2.81 KB

Patch inserts some asserts demonstrating the problem.

znerol’s picture

znerol commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: 2430133-demo-broken-block-language-test.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
StatusFileSize
new blocklanguagetest_tests-2430133-4.patch2.24 KB

Rerolled the patch from #1. Only 3 out of 6 occurrences failed locally. Let's see what testbot thinks of this.

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes

Added beta eval.

mgifford’s picture

mgifford
he/him
Primary language English
commented
StatusFileSize
new blocklanguagetest_tests-2430133-4.patch2.24 KB

Re-uploading patch for the bots.

Status: Needs review » Needs work

The last submitted patch, 6: blocklanguagetest_tests-2430133-4.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Version: 9.3.x-dev » 9.4.x-dev
Status: Needs work » Needs review
Issue tags: +Bug Smash Initiative
StatusFileSize
new 2430133-18.patch2.03 KB

Status: Needs review » Needs work

The last submitted patch, 18: 2430133-18.patch, failed testing. View results

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new 2430133-20.patch3.65 KB
new interdiff-2430133-18-20.txt3.54 KB
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 2430133-21.patch3.63 KB

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Version: 9.5.x-dev » 10.0.x-dev
StatusFileSize
new 2430133-21.patch3.63 KB

I reviewed the patch in #21. The changes look correct to me. It still applies to D10 and the modified test passes locally.

Uploading again to move to D10. I plan to RTBC after tests run.

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

As expected tests are passing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 23: 2430133-21.patch, failed testing. View results

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Reviewed & tested by the community

Unrelated test failures.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 10.0.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed b8a325c351 to 10.0.x and 080690741d to 9.5.x and 7d583738ac to 9.4.x. Thanks!

As #23 was only to prove the tests pass on D10 and is exactly the same as #21 I've removed credit for @quietone.

Backported to 9.4.x as a test-only change.

  • alexpott committed b8a325c on 10.0.x 
    Issue #2430133 by JeroenT, znerol, mgifford: BlockLanguageTest tests non...

  • alexpott committed 0806907 on 9.5.x 
    Issue #2430133 by JeroenT, znerol, mgifford: BlockLanguageTest tests non...

  • alexpott committed 7d58373 on 9.4.x 
    Issue #2430133 by JeroenT, znerol, mgifford: BlockLanguageTest tests non...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.