[D7] Node title help text

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Git clone failed for http://git.drupal.org/sandbox/jadhavdevendra/2423373.git while invoking http://pareview.sh/pareview/httpgitdrupalorgsandboxjadhavdevendra2423373git

Git clone failed. Aborting.

I'm a robot and this is an automated message from Project Applications Scraper.

It looks like you need to change line 40 in node_title_help_text.module from:

* @param &$form_state

to

* @param array &$form_state

I think you should add a .install file to uninstall variables.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

#3 , #6

Hi Devendra..

You have mentioned the @param in comment in submit handler. Drupal does not allow the @params in submit, validate handlers.

Your submit handler is:
/**
* Submit handler for node type form. Stores help text in variable.
*
* @param string $form_id
* The unique string identifying the desired form.
* @param array &$form_state
* A keyed array containing the current state of the form.
*/
function node_title_help_text_node_type_form_submit($form_id, &$form_state) {
// In case of change of machine name, remove the old variable.
if (isset($form_state['values']['old_type'])) {
$old_name = 'node_title_help_text_' . $form_state['values']['old_type'] . '_title_help';
variable_del($old_name);
}
$name = 'node_title_help_text_' . $form_state['values']['type'] . '_title_help';
$value = $form_state['values']['title_help'];
variable_set($name, $value);
}

You need to remove both @params from comments.

Just remove below line of code:
* @param string $form_id
* The unique string identifying the desired form.
* @param array &$form_state
* A keyed array containing the current state of the form.

You can follow section "Form-generating functions" in https://www.drupal.org/coding-standards/docs .

Hi Devendra,

Thanks for your contribution.

Nice and simple module.
Have you looked into Label Help. I think it does the same job for form fields. I guess it would be a good idea to merge your module with that.

Just a suggestion..Otherwise looks ok to me.. :-)

@jadhavdevendra ,
Please specify the differences on your project page and also in the issue summary how your module is different from the above mentioned Label Help module
@Swarnendu-Dutta,
Is there anything else that you found blocker and stopped you to set it to RTBC ?

@naveenvalecha,

All looks ok...i dint find anything else..just that this module can be merged with Label Help as both are on the same page..

Please check with existing module available like https://www.drupal.org/project/title_field_ui and follow ways to contribute - https://www.drupal.org/contribute/development

It would be better if you can contribute a patch to other modules.

First, I think this module is a great idea and absolutely needed!

Automated Review

No best practice issues identified by pareview.sh : http://pareview.sh/pareview/httpgitdrupalorgsandboxjadhavdevendra2423373git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Does not cause module duplication and/or fragmentation.
I agree with jadhavdevendra. Although there are similarities to other modules, this is a different direction and usage. However, I'm going to leave this in "Needs work" until the project page references similar modules and when to use this vs. them.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements. / No: List of security issues identified.]

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) Major finding, needs work
2. (+) Release blocker
3. Just a recommendation
4. ...]

• (+) The project page needs to reference similar modules and when to use this vs. them.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

setting this to RTBC...

Thanks for your contribution @jadhavdevendra,

Automated Review

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Follows the guidelines for in-project documentation and/or the README Template.Please move the configurations to the Configuration section.

Code long/complex enough for review

Maybe: Follows the guidelines for project length and complexity.The module has 5 functions but the code is not more than 120 lines.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. The Git commits are not connected to your user account. You need to specify an email address.See https://www.drupal.org/node/1022156 and https://www.drupal.org/node/1051722
2. hook_help() is missing in this module.
3. It would be nice if you also add the configuration page to select the node types on which administer select the content types of node Title field helptext.
4. All variables should be with default values .
5. node_title_help_text_form_node_form_alter : $form['title']['#description'] = nl2br(field_filter_xss($description));I think the nl2br is not needed here.Please add a comment. That's fine to use it like that.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Removed comments that were not source code reviews.

manual review:

1. "'#title' => 'Title field helptext',": all user facing text must run through t() for translation.
2. This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Otherwise looks good to me. I think this a lot simpler than the existing modules, so IMO the duplication is justified.

Thanks for your contribution, jadhavdevendra !

I have promoted this project for you: https://www.drupal.org/project/node_title_help_text

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.