Comments

lolandese’s picture

Issue tags: +ninja
lolandese’s picture

Related issues: +#2505955: Configurable CSS
lolandese’s picture

Status: Active » Needs work
StatusFileSize
new8.51 KB

The attached patch fulfills the request but only for the caption font size.

To do:

  • Include CSS variables for the Flickr Style sub-module.
  • Add form field validation (e.g. font size must be a positive number).
  • Extract the concerning CSS in a separate file to make that the rest still gets aggregated.
lolandese’s picture

StatusFileSize
new15.88 KB

Added field validation. Also improves some existing ones by demanding specifically an integer instead of just a number that can be also a float. That didn't make sense for some fields e.g. those specifying a number of photos to display.

lolandese’s picture

StatusFileSize
new18.23 KB

Attached patch extracts the concerning CSS in a separate file to make that the rest still gets aggregated.

Furthermore it adds the CSS variable for slideshow width, unit and ratio.

lolandese’s picture

To move on to Flickr Style variables.

lolandese’s picture

StatusFileSize
new34.44 KB

For a start the patch adds a configurable rounded corners radius.

lolandese’s picture

Status: Needs work » Postponed
Related issues: +#2512364: Extend to modules besides themes

Despite the #7 patch works as expected, we suspect that implementing it for many other CSS elements will over-complicate the code. Instead we wrote a patch for the Style (CSS) Settings module at #2512364: Extend to modules besides themes.

Once that is through we'll only have to wrap the intended CSS variables in comments and provide a UI to set them.

lolandese’s picture

Status: Postponed » Needs review
StatusFileSize
new32.59 KB

The attached patch does all the previous but instead leverages the Style (CSS) Settings module. This not only simplifies the code but is also universally applicable on other modules. Note that the patch includes a lot of other small unrelated improvements as well.

lolandese’s picture

StatusFileSize
new44.9 KB

Does all the previous plus color support. Note that also the patch of #2528252: Offer a ColorPicker API form element type for developers must be applied on the Style Settings module.

lolandese’s picture

lolandese’s picture

Status: Needs review » Needs work
StatusFileSize
new49.51 KB

Just saving some work.

lolandese’s picture

Status: Needs work » Needs review
Related issues: +#2533666: Offer an image URL form API element for developers
StatusFileSize
new58.61 KB
lolandese’s picture

StatusFileSize
new64.33 KB
lolandese’s picture

StatusFileSize
new77.18 KB
lolandese’s picture

StatusFileSize
new79.29 KB
lolandese’s picture

Status: Needs review » Fixed
StatusFileSize
new80.15 KB

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.