Closed (fixed)
Project:
Flickr
Version:
7.x-1.x-dev
Component:
flickrstyle
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Feb 2015 at 16:56 UTC
Updated:
12 Aug 2015 at 10:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
lolandese commentedComment #2
lolandese commented#2505955: Configurable CSS provides a solution. An alternative could be https://www.drupal.org/project/style_settings.
Comment #3
lolandese commentedThe attached patch fulfills the request but only for the caption font size.
To do:
Comment #4
lolandese commentedAdded field validation. Also improves some existing ones by demanding specifically an integer instead of just a number that can be also a float. That didn't make sense for some fields e.g. those specifying a number of photos to display.
Comment #5
lolandese commentedAttached patch extracts the concerning CSS in a separate file to make that the rest still gets aggregated.
Furthermore it adds the CSS variable for slideshow width, unit and ratio.
Comment #6
lolandese commentedTo move on to Flickr Style variables.
Comment #7
lolandese commentedFor a start the patch adds a configurable rounded corners radius.
Comment #8
lolandese commentedDespite the #7 patch works as expected, we suspect that implementing it for many other CSS elements will over-complicate the code. Instead we wrote a patch for the Style (CSS) Settings module at #2512364: Extend to modules besides themes.
Once that is through we'll only have to wrap the intended CSS variables in comments and provide a UI to set them.
Comment #9
lolandese commentedThe attached patch does all the previous but instead leverages the Style (CSS) Settings module. This not only simplifies the code but is also universally applicable on other modules. Note that the patch includes a lot of other small unrelated improvements as well.
Comment #10
lolandese commentedDoes all the previous plus color support. Note that also the patch of #2528252: Offer a ColorPicker API form element type for developers must be applied on the Style Settings module.
Comment #11
lolandese commentedComment #12
lolandese commentedJust saving some work.
Comment #13
lolandese commentedFirst apply the patch of #2533666: Offer an image URL form API element for developers.
Comment #14
lolandese commentedComment #15
lolandese commentedComment #16
lolandese commentedComment #17
lolandese commented