The used target class '.content', officially stiil part of the Standard Drupal core classes, is not used by some themes anymore, likely due to the upcoming HTML5 tag 'article'.

We could use '.node' instead, but that would miss out on other entities. Using the HTML5 tag would not be CSS targetable by IE8 and before. There are workarounds for that, but that means other soft dependencies.

Best would be to have it configurable, but configurable CSS is still on the wish list.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lolandese’s picture

Status: Active » Needs work
FileSize
1.12 KB

A first shot at this. It works but is still missing a UI to set the variable 'autofloat_target', currently set to a default of 'article' that works with the Bootstrap theme.

lolandese’s picture

FileSize
2.67 KB

Better to include the new file in the patch.

lolandese’s picture

Status: Needs work » Needs review
FileSize
8.39 KB

lolandese’s picture

Status: Needs review » Fixed
lolandese’s picture

Category: Bug report » Feature request
Status: Fixed » Needs work

Add validation for the margin form field to ensure it's a positive number.

lolandese’s picture

Status: Needs work » Needs review
FileSize
6.13 KB

lolandese’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

lolandese’s picture

Status: Closed (fixed) » Needs work

Put back in the CSS selectors .content, #content and add article. This way we cover out-of-the-box for most of the themes available (if not all).

Furthermore now that we've added module support in the Style (CSS) Settings module, rewrite the code to have configurable CSS that way. It is much less code intrusive if no configurable CSS is desired.

lolandese’s picture

Title: AutoFloat's CSS does not apply in newer version of Bootstrap » Configurable CSS
Status: Needs work » Fixed
FileSize
27.37 KB

Added article as CSS selector. Furthermore added a preview and CSS variables through the Style (CSS) Settings module.

lolandese’s picture

Status: Fixed » Needs review
FileSize
4.31 KB

Attached patch adds a configurable CSS selector. Bootstrap uses for example the HTML tag article. Most universal seems .node to target only the node and not the blocks. We made that the default value.

Furthermore we added the specific flickr selectors to avoid override of AutoFloat's CSS by Flickr's CSS.

  • lolandese committed 0925251 on 7.x-2.x
    Issue #2505955: Configurable CSS selector and avoid being overridden by...
lolandese’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.