All automated tests should be placed in PSR-4 namespaces.

Change record: Namespace and naming changes for test classes of automated tests.

In order to avoid "double work", this issue should wait until #2122013 Separate tests that depend on the Date module is committed.

CommentFileSizeAuthor
#8 2418543-relocated-automated-tests-1.patch2.25 KBlegovaer

Comments

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Issue summary: View changes
Status: Active » Postponed
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Related issues: +#2122013: Separate tests that depend on the Date module
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Postponed » Active

#2122013: Separate tests that depend on the Date module has landed. This is unblocked now.

zealfire’s picture

zealfire commented
Assigned: Unassigned » zealfire
zealfire’s picture

zealfire commented

Sorry am i missing something,because i can't find automated tests in dev version of scheduler.Please help me.
Thanks.

pfrenssen’s picture

pfrenssen
Location Sofia
commented

The main test is scheduler.test. There is also scheduler_api.test which is testing the hooks and is accompanied by a small testing module called "scheduler_test".

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Assigned: zealfire » legovaer
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
StatusFileSize
new 2418543-relocated-automated-tests-1.patch2.25 KB

Relocated the automated tests, but will fail because of Use Utility\SafeMarkup class instead of Utility\String for placeholder(), checkPlain(),format() functions.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Active » Needs review
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Issue tags: +Needs reroll

Patch doesn't apply any more.

  • pfrenssen committed ddd5a03 on 8.x-1.x authored by legovaer 
    Issue #2418543 by legovaer: Relocate automated tests in PSR-4 namespaces...
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Assigned: legovaer » Unassigned
Status: Needs review » Fixed
Issue tags: -Needs reroll

Rebased on 8.x-1.x. It looks good but I haven't actually tried to run the tests yet. The main focus of the coming weeks will be to port and extend the test coverage. First things will be to split them up into separate files and move them in the right location.

Committed to 8.x-1.x, thanks a lot for your work!

jonathan1055’s picture

jonathan1055 commented

Thank you all for putting in this time and effort on the 8.x conversion, it is appreciated.

Jonathan

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.