In #1069668: Default time with user override a test was added that depends on the Date module. The "date" and "date_popup" modules are now enabled in the general setUp() method meaning they are enabled also for tests that do not depend on them. We should split off this test in a separate class.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

legovaer’s picture

Assigned: Unassigned » legovaer
Issue summary: View changes
Status: Active » Needs review
FileSize
24.72 KB

Created one common helper class and separated all the testcases into two additional classes. Tested locally on 7.34.

pfrenssen’s picture

FileSize
24.95 KB

Sorry for not looking at this earlier, I was preoccupied with the D8 port.

This looks really good. I have made a small tweak: the original SchedulerTestCase class is now a base class, so I renamed it to SchedulerTestBase and made it abstract. For the rest it looks perfect.

Uploading the tweaked patch so the bot can have a go at it. If this comes back green this is RTBC for me.

  • pfrenssen committed eac8d54 on 8.x-1.x authored by legovaer
    Issue #2122013 by legovaer, pfrenssen: Separate tests that depend on the...
pfrenssen’s picture

Assigned: legovaer » Unassigned
Status: Needs review » Fixed

Excellent, committed to 7.x-1.x and also to 8.x-1.x. It was quite a lot of work to port it to the D8 branch, took about 30 minutes of comparing it line by line, hopefully I didn't miss anything :)

  • pfrenssen committed ca76a00 on 7.x-1.x authored by legovaer
    Issue #2122013 by legovaer: Separate tests that depend on the Date...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.