Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
In #1069668: Default time with user override a test was added that depends on the Date module. The "date" and "date_popup" modules are now enabled in the general setUp() method meaning they are enabled also for tests that do not depend on them. We should split off this test in a separate class.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2122013-seperated-testcases-2.patch | 24.95 KB | pfrenssen |
Comments
Comment #1
legovaerCreated one common helper class and separated all the testcases into two additional classes. Tested locally on 7.34.
Comment #2
pfrenssenSorry for not looking at this earlier, I was preoccupied with the D8 port.
This looks really good. I have made a small tweak: the original
SchedulerTestCase
class is now a base class, so I renamed it toSchedulerTestBase
and made it abstract. For the rest it looks perfect.Uploading the tweaked patch so the bot can have a go at it. If this comes back green this is RTBC for me.
Comment #4
pfrenssenExcellent, committed to 7.x-1.x and also to 8.x-1.x. It was quite a lot of work to port it to the D8 branch, took about 30 minutes of comparing it line by line, hopefully I didn't miss anything :)